HUE-8638 [importer] Enable context popover and syntax error highlighting in the importer field editor

Review Request #13472 - Created Oct. 23, 2018 and submitted

Johan Åhlén
hue
master
hue
jgauthier, ranade, romain, roohi, weixia, yingc
commit b11d426983575f864480c2684779a362bc8f3609
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Tue Oct 23 14:36:26 2018 +0200

    HUE-8638 [importer] Enable context popover and syntax error highlighting in the importer field editor

:100644 100644 138322ffa8 fe0dd24d59 M	desktop/core/src/desktop/static/desktop/js/ko.hue-bindings.js
:100644 100644 3d0383d9a6 b520018fc2 M	desktop/core/src/desktop/static/desktop/js/sqlUtils.js
:100644 100644 1b00bfc704 357276c96a M	desktop/core/src/desktop/static/desktop/spec/sqlAutocompleter3Spec.js
:100644 100644 b2c0b8056e 4f015bb244 M	desktop/core/src/desktop/templates/ko_components/ko_simple_ace_editor.mako
:100644 000000 43d22dad52 0000000000 D	desktop/libs/notebook/src/notebook/templates/workers_embedded.mako

commit 97199482f1f7cfdf2dd761094fe816928e15a9c1
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Tue Oct 23 14:37:04 2018 +0200

    HUE-8638 [core] Remove dead webworker code for embedded mode

:100644 100644 495ddb9895 138322ffa8 M	desktop/core/src/desktop/static/desktop/js/ko.hue-bindings.js
:100644 100644 68bb3fd638 c5e07dd674 M	desktop/core/src/desktop/templates/ace_sql_syntax_worker.mako
:100644 100644 be57b22931 8898cf2205 M	desktop/libs/notebook/src/notebook/urls.py
:100644 100644 22bdddfd5c aea629f4d6 M	desktop/libs/notebook/src/notebook/views.py

commit 91b7e4b7b4be34ec5dbc94e6144d308363bc2386
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Tue Oct 23 13:04:08 2018 +0200

    HUE-8638 [frontend] Disable operations in the context popover for temporary entries

:100644 100644 b980e099ad fbed16e970 M	desktop/core/src/desktop/templates/ko_components/ko_catalog_entries_table.mako
:100644 100644 c86e369536 544e8692ec M	desktop/core/src/desktop/templates/ko_components/ko_context_popover.mako

commit c6f06489c204165afb93470e8334ff76b74be536
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Tue Oct 23 12:57:25 2018 +0200

    HUE-8638 [frontend] Enable breadcrumb navigation in the context popover for temporary entries

:100644 100644 09445ba452 25f2a21cc4 M	desktop/core/src/desktop/static/desktop/js/dataCatalog.js
:100644 100644 55f9839577 c86e369536 M	desktop/core/src/desktop/templates/ko_components/ko_context_popover.mako

commit 740c1389df4a2a6fe33f9634a263ed93c8d7f767
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Tue Oct 23 12:53:36 2018 +0200

    HUE-8638 [frontend] Add samples to temporary catalog entries

:100644 100644 912e96fe49 09445ba452 M	desktop/core/src/desktop/static/desktop/js/dataCatalog.js
:100644 100644 8ae018e4de a931652151 M	desktop/libs/indexer/src/indexer/templates/importer.mako

commit 55f525307118ab796b6afc9cf36cca700ebbf156
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Tue Oct 23 12:36:22 2018 +0200

    HUE-8638 [frontend] Make sure a temporary source is created in the data catalog for temporary tables

:100644 100644 160106d565 912e96fe49 M	desktop/core/src/desktop/static/desktop/js/dataCatalog.js

commit af6b4244dabab3431949a3f38a9cb0175a6440b2
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Mon Oct 22 15:43:48 2018 +0200

    HUE-8638 [editor] Move context popover and tooltip logic out of the aceEditor binding

:100644 100644 a615864bb2 495ddb9895 M	desktop/core/src/desktop/static/desktop/js/ko.hue-bindings.js

commit b1e0243b62d7deee0d7b8ece10ab620fedf941cf
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Mon Oct 22 15:18:50 2018 +0200

    HUE-8638 [editor] Extract editor webworker logic to global handler
    
    To be able to use the context popover in editors outside of the editor

:100644 100644 c690d6499a a615864bb2 M	desktop/core/src/desktop/static/desktop/js/ko.hue-bindings.js
:100644 100644 e698bb7e23 d0db48d0de M	desktop/libs/notebook/src/notebook/templates/editor_components.mako
Manual on Chrome

https://dl.dropbox.com/s/ggym222yephm9lm/Screenshot%202018-10-23%2014.38.56.png?dl=0
https://dl.dropbox.com/s/8b8oewdrpwarm45/Screenshot%202018-10-23%2014.39.25.png?dl=0
https://dl.dropbox.com/s/5jgo13mt6vxldrb/Screenshot%202018-10-23%2014.39.58.png?dl=0
  1. Nice, massive clean-up!

  2. 
      
Review request changed

Status: Closed (submitted)

Loading...