Testing Done: |
|
---|
Adding celery to the system
Review Request #13627 — Created Feb. 15, 2019 and updated
Information | |
---|---|
ranade | |
hue | |
master | |
Reviewers | |
hue | |
jgauthier, johan, ranade, romain, subrata, weixia, yingc |
commit 00df0f92afdc85d9bf4b9e7d369ed26343d40c3b Author: Prakash Ranade <ranade@cloudera.com> Date: Wed Feb 13 18:16:32 2019 -0800 Adding celery to the Hue app (cherry picked from commit 0f14407ec7c826a00fad57195864cf2f21ba7615) :000000 100644 0000000000 467bc335a6 A apps/useradmin/src/useradmin/tasks.py :100644 100644 3f38a273b7 9af4914a3f M apps/useradmin/src/useradmin/views.py :100644 100644 25dfeca8e2 d7a17fb869 M desktop/core/src/desktop/settings.py :000000 100644 0000000000 bfb2056f7c A desktop/libs/notebook/src/notebook/tasks.py :100644 100644 aea629f4d6 b3216cc133 M desktop/libs/notebook/src/notebook/views.py
tested file download through celery worker.
- 4
- 0
- 0
- 0
- 4
Description | From | Last Updated |
---|---|---|
Could all of this be configurable via hue.ini? |
|
|
Here seems like you connect to Hue to download the query result, which defeats the whole purpose of doing the ... |
|
|
Instead of a __main__, could we have a tasks_tests.py instead? |
|
|
Could we avoid full duplication of the methods? e.g. if task server is enabled, we return the task_id, if not, ... |
|
-
-
desktop/core/src/desktop/settings.py (Diff revision 1) Could all of this be configurable via hue.ini?
-
desktop/libs/notebook/src/notebook/tasks.py (Diff revision 1) Here seems like you connect to Hue to download the query result, which defeats the whole purpose of doing the download in a task.
Would recommend to focus on the HDFS file compression/extraction instead. The full notebook API (exec, fetch status, download, profile...) will be ported to the task system by JF.
-
desktop/libs/notebook/src/notebook/tasks.py (Diff revision 1) Instead of a __main__, could we have a tasks_tests.py instead?
-
desktop/libs/notebook/src/notebook/views.py (Diff revision 1) Could we avoid full duplication of the methods?
e.g.
if task server is enabled, we return the task_id, if not, we do like before?