HUE-8768 [editor] Clean up the snippet model to prepare for notebook 2

Review Request #13755 - Created March 27, 2019 and updated

Johan Åhlén
hue
master
hue
jgauthier, ranade, romain, roohi, weixia, yingc
commit 4e81e0ccc4ea0230d53410f3cebf5d41355fccb6
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Mar 27 16:20:22 2019 +0100

    HUE-8768 [editor] Clean up the snippet model to prepare for notebook 2

:100644 100644 ea91749e41 854312361a M	apps/beeswax/src/beeswax/templates/execute.mako
:100644 100644 b9d55c7b41 143e91cf66 M	desktop/core/src/desktop/js/apps/notebook/snippet.js
:100644 100644 7380c6382d 241e5d81b8 M	desktop/core/src/desktop/js/apps/notebook/spec/aceAutocompleteWrapperSpec.js
:100644 100644 2ad8c6a0bd f6a9079d71 M	desktop/core/src/desktop/js/apps/notebook2/editorViewModel.js
:100644 100644 bb76aa1cc2 a0f8fff1d8 M	desktop/core/src/desktop/js/apps/notebook2/notebook.js
:100644 100644 37fbb44d55 c52e700ffd M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 588d34eeda 57c90d1d82 M	desktop/core/src/desktop/js/ko/bindings/ko.aceResizer.js
:100644 100644 9254009c7f f889b6855e M	desktop/core/src/desktop/js/parse/spec/sqlAutocompleteParser_Locations_Spec.js
:100644 100644 5dd4828155 1a5a80f1b8 M	desktop/core/src/desktop/js/parse/sqlParseSupport.js
:100644 100644 f0d302e922 80fbdb7272 M	desktop/core/src/desktop/js/utils/spec/hdfsAutocompleterSpec.js
:100644 100644 9991c19506 cdb5d7e4b7 M	desktop/libs/notebook/src/notebook/templates/editor_components.mako

commit 8e2e8aac9e250979518affaf98dfeeef910468ca
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Mar 27 12:17:30 2019 +0100

    HUE-8768 [editor] Add a feature flag for notebook2
    
    [notebook]
      enable_notebook_2=true

:000000 100644 0000000000 2ad8c6a0bd A	desktop/core/src/desktop/js/apps/notebook2/editorViewModel.js
:000000 100644 0000000000 bb76aa1cc2 A	desktop/core/src/desktop/js/apps/notebook2/notebook.js
:000000 100644 0000000000 d56307d56b A	desktop/core/src/desktop/js/apps/notebook2/result.js
:000000 100644 0000000000 c44504a6ec A	desktop/core/src/desktop/js/apps/notebook2/session.js
:000000 100644 0000000000 37fbb44d55 A	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 a279f5ff7a 649416639d M	desktop/core/src/desktop/js/hue.js
:100644 100644 cd63797357 442eabe71d M	desktop/core/src/desktop/templates/global_js_constants.mako
:100644 100644 44062ab1c8 6db0924002 M	desktop/libs/notebook/src/notebook/conf.py
Manual on Chrome
  1. Push https://review.cloudera.org/r/13756/ before?

    If we need to modify notebook2 in the meantime, should we just avoid it? (to avoid conflicts)

    1. I can monitor and migrate the incoming changes. Couldn't find a clean way with just using the flag as conditions within as the structure changes quite a bit.

  2. 
      
Loading...