[jobbrowser] Can't reload job in mini job browser

Review Request #13760 - Created March 27, 2019 and submitted

Mykhailo Kysliuk
hue
hue
romain

From 3a4ae36a230aa10ea7a339fdf9d84f0fc5ff75f2 Mon Sep 17 00:00:00 2001
From: Mykhailo Kysliuk misha.kysliuk@gmail.com
Date: Wed, 27 Mar 2019 22:53:27 +0200
Subject: [PATCH] HUE-8771: [jobbrowser] Can't reload job in mini job browser

Link to JIRA - https://issues.cloudera.org/browse/HUE-8771
Link to PR - https://github.com/cloudera/hue/pull/824

Manual on chrome.

  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
  1. 
      
  2. Would be cleaner to use the event on the modal $('#rerun-modal${ SUFFIX }').on('shown', function (e) {
    var rerunModalData = $(this).data('modal');
    rerunModalData.$backdrop.appendTo("#jobbrowserMiniComponents");
    });

    this could go at line 2615

    1. We could fix this issue in another way:
      Move this part:
      <!-- ko if: $root.job() -->
      <div id="rerun-modal${ SUFFIX }" class="modal hide" data-bind="htmlUnsecure: $root.job().rerunModalContent"></div>
      <!-- /ko -->
      outside of 'jobbrowserMiniComponents' in order not to inherit parent z-index and apply knockout js bindings to the higher scope element:
      Was:
      ko.applyBindings(jobBrowserViewModel, $('#jobbrowserComponents')[0]);
      Change to:
      ko.applyBindings(jobBrowserViewModel, $('span.notebook')[0]);

      This will not change the bootstrap structure of modal window, which backdrop is appended to the end of body tag.

      Which solution will be better:
      1. Move bootstrap backdrop from body to the closer scope element
      2. Change apply bindings of knockout js and move rerun-modal element

      Please suggest on this.

  3. 
      
  1. Ship It!
  2. 
      
Review request changed

Status: Closed (submitted)

Loading...