HUE-8777 [jb] Improve diagnostics display on yarnv2 jobs

Review Request #13771 - Created March 29, 2019 and submitted

Jean-Francois Desjeans Gauthier
hue
master
HUE-8777
hue
jgauthier
commit ac14a7b625993ebec65d39d723b4a2bb78ce19db
Author: jdesjean <jgauthier@cloudera.com>
Date:   Fri Mar 29 15:58:23 2019 -0700

    HUE-8777 [jb] Improve diagnostics display on yarnv2 jobs

:100644 100644 a4355cf718... f84fc4b6fc... M	apps/jobbrowser/src/jobbrowser/apis/job_api.py
:100644 100644 4900b1b67e... 9e8a9bd3db... M	apps/jobbrowser/src/jobbrowser/templates/job_browser.mako
:100644 100644 75b5a170e4... f7de1fda41... M	apps/jobbrowser/src/jobbrowser/views.py
:100644 100644 098411b14c... a2fa577ac3... M	apps/jobbrowser/src/jobbrowser/yarn_models.py
:100644 100644 2f3c5b46be... bbdf91db4b... M	desktop/libs/notebook/src/notebook/api.py
:100644 100644 7a855d5ce6... 38d065596d... M	desktop/libs/notebook/src/notebook/tasks.py


  • 1
  • 0
  • 2
  • 0
  • 3
Description From Last Updated
nit: add comment that this is typically for diagnostics? Romain Rigaux
  1. Would 'hasDiagnostics' be reusable for non YARN jobs at some point later? (e.g. maybe for queries hints etc,..)
    (here we are coupling and adding a bunch of YARN specific stuff in the model).

    Actually: could we have the YARN diagnostic logic moved to the the YARN connector? (if we don't display the attribute like before, better to inject it as a 'default' or one of the other type of logs so that the code stays generic/simple)

  2. nit: Curly braces?

    Bit "fishy" to add a corner case like this

  3. Could we avoid the dedup before cleanly somehow?
    (e.g. "diagnostic" are added to the 'default' logs of YARN automatically in the YARN connector)

    If not one liner to avoid creating a new function?

    e.g. filter()

    https://stackoverflow.com/questions/1584370/how-to-merge-two-arrays-in-javascript-and-de-duplicate-items

  4. 
      
  1. 
      
  2. nit: add comment that this is typically for diagnostics?

  3. 
      
Review request changed

Status: Closed (submitted)

Loading...