HUE-8740 [sql] Add create_session to sqlalchemy & cache engine.
Review Request #13783 - Created April 3, 2019 and updated
|Jean-Francois Desjeans Gauthier|
commit e4736aad74c9ab7c548db30073ab7fe9cdeee73e Author: jdesjean <firstname.lastname@example.org> Date: Wed Apr 3 11:55:50 2019 -0700 HUE-8740 [sql] Add create_session to sqlalchemy & cache engine. :100644 100644 bbdf91db4b... 63ca01538a... M desktop/libs/notebook/src/notebook/api.py :100644 100644 a944ef9d9e... bcfe1b65ab... M desktop/libs/notebook/src/notebook/connectors/sqlalchemyapi.py
What is the goal of caching? When we have:
- Hue server only: keep open for downloading the result later without redoing the query?
- Hue server + Task server: still needed?
Could merge back these 2 too
Could also remove https://github.com/cloudera/hue/blob/master/desktop/libs/notebook/src/notebook/connectors/base.py#L340 for now
We probably are going to leak stuff, could we use Django cache framework and TTL?
Seems wrong to have one engine cache for everything?
Do we really need those here and below?
(for me it means more that we forgot to call create_session())