HUE-8747 [editor] Fix download arguments for task.

Review Request #13784 - Created April 3, 2019 and submitted

Jean-Francois Desjeans Gauthier
hue
master
HUE-8747
hue
jgauthier
commit 16e9fe1037bf745a91ba80a49da32858ebf64dbb
Author: jdesjean <jgauthier@cloudera.com>
Date:   Wed Apr 3 14:10:49 2019 -0700

    HUE-8747 [editor] Fix download arguments for task.

:100644 100644 795249e8fd... 09481a15ca... M	desktop/libs/notebook/src/notebook/connectors/base.py
:100644 100644 16824b73c5... b7a88ff077... M	desktop/libs/notebook/src/notebook/connectors/hiveserver2.py
:100644 100644 e6fcd91543... 804f911207... M	desktop/libs/notebook/src/notebook/connectors/jdbc.py
:100644 100644 7b10ecede8... b9f153569c... M	desktop/libs/notebook/src/notebook/connectors/rdbms.py
:100644 100644 7f0b3a3763... 240c0fe650... M	desktop/libs/notebook/src/notebook/connectors/solr.py
:100644 100644 8fea48bdeb... aafc86d214... M	desktop/libs/notebook/src/notebook/connectors/spark_shell.py
:100644 100644 a944ef9d9e... fab86b05bc... M	desktop/libs/notebook/src/notebook/connectors/sqlalchemyapi.py

librdbms, jdbc, sqlalchemy, hs2
both old & task api

  • 0
  • 0
  • 7
  • 2
  • 9
Description From Last Updated
  1. 
      
  2. We keep adding stuff to the notebook.download API, would it make sense to move the format/data_export stuff to https://github.com/cloudera/hue/blob/master/desktop/libs/notebook/src/notebook/views.py#L341 instead?

    download could return a stream/file

  3. 
      
  1. Nice!

    First pass of high level things, but looking great!

  2. apps/beeswax/src/beeswax/data_export.py (Diff revision 3)
     
     

    Shouldn't all of this be in the notebook lib instead?

  3. apps/beeswax/src/beeswax/data_export.py (Diff revision 3)
     
     

    , --> as

    (Py3 compatibility)

  4. +1 (but no need right now, other task to move editor properties to notebook instead of beeswax)

  5. nit: could also call parent

  6. Could this be moved into the notebook lib? (or desktop/lib, just to keep available all the time)

  7. Is it here because of import issue?

    (will make sure the apps/beeswax is never blacklisted with https://issues.cloudera.org/browse/HUE-8330)

  8. 
      
Review request changed

Status: Closed (submitted)

Loading...