HUE-8768 [editor] Switch to showing the results from the executor in notebook 2

Review Request #13812 - Created April 11, 2019 and submitted

Johan Åhlén
hue
master
hue
jgauthier, ranade, romain, roohi, weixia, yingc
commit 6cf25c7714a41656f3c90212a298304a3a028840
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu Apr 11 16:38:07 2019 +0200

    HUE-8768 [editor] Switch to showing the results from the executor in notebook 2

:100644 100644 7d4d13efd9 8c1aa27830 M	desktop/core/src/desktop/js/api/apiHelper.js
:100644 100644 710ea4d309 d4e582a314 M	desktop/core/src/desktop/js/apps/notebook2/execution/executableStatement.js
:100644 100644 9ab077f61f c631487406 M	desktop/core/src/desktop/js/apps/notebook2/execution/executionResult.js
:100644 100644 32f75eeaff 51ea146dab M	desktop/core/src/desktop/js/apps/notebook2/execution/executor.js
:100644 100644 e2748dae1b 0c9d96a584 M	desktop/core/src/desktop/js/apps/notebook2/execution/sessionManager.js
:100644 100644 0f7d15c8f9 b98805d9f3 M	desktop/core/src/desktop/js/apps/notebook2/execution/spec/executableStatementSpec.js
:100644 100644 657012e832 257d814723 M	desktop/core/src/desktop/js/apps/notebook2/execution/spec/executorSpec.js
:100644 100644 70eaf0731d e0b3736422 M	desktop/core/src/desktop/js/apps/notebook2/result.js
:100644 100644 f9eb3087b7 b01d428bd2 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 cf982e360a d5c8d90a35 M	desktop/core/src/desktop/js/ko/bindings/ko.autocomplete.js

commit 3c99327fdf6974ae8c740c20b1a6cc0d7a27f8f8
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Apr 10 15:26:33 2019 +0200

    HUE-8768 [editor] Implement the execute and check status functionality for notebook 2

:100644 100644 7764519cc5 7d4d13efd9 M	desktop/core/src/desktop/js/api/apiHelper.js
:100644 100644 5a46f4c457 6a1e2f561d M	desktop/core/src/desktop/js/api/cancellablePromise.js
:100644 000000 4290f8a189 0000000000 D	desktop/core/src/desktop/js/apps/notebook2/executableStatement.js
:000000 100644 0000000000 710ea4d309 A	desktop/core/src/desktop/js/apps/notebook2/execution/executableStatement.js
:000000 100644 0000000000 9ab077f61f A	desktop/core/src/desktop/js/apps/notebook2/execution/executionResult.js
:100644 100644 44f7f8df53 32f75eeaff R085	desktop/core/src/desktop/js/apps/notebook2/executor.js	desktop/core/src/desktop/js/apps/notebook2/execution/executor.js
:000000 100644 0000000000 e2748dae1b A	desktop/core/src/desktop/js/apps/notebook2/execution/sessionManager.js
:100644 100644 0f7d15c8f9 0f7d15c8f9 R100	desktop/core/src/desktop/js/apps/notebook2/spec/executableStatementSpec.js	desktop/core/src/desktop/js/apps/notebook2/execution/spec/executableStatementSpec.js
:100644 100644 657012e832 657012e832 R100	desktop/core/src/desktop/js/apps/notebook2/spec/executorSpec.js	desktop/core/src/desktop/js/apps/notebook2/execution/spec/executorSpec.js
:100644 100644 710d00687c 70eaf0731d M	desktop/core/src/desktop/js/apps/notebook2/result.js
:100644 100644 5f6c0858f3 f9eb3087b7 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 21ca849474 5563072338 M	desktop/core/src/desktop/js/catalog/dataCatalog.js

commit 98e310f0047c7645e4207090a45067ccc590d351
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Tue Apr 2 17:28:44 2019 +0200

    HUE-8768 [editor] Add initial version executor and executableStatement for notebook 2

:100644 100644 d49e01ee83 7764519cc5 M	desktop/core/src/desktop/js/api/apiHelper.js
:100644 100644 92e4d8a32b 5a46f4c457 M	desktop/core/src/desktop/js/api/cancellablePromise.js
:100644 100644 01826d4d32 210175e1ef M	desktop/core/src/desktop/js/apps/notebook/notebook.js
:100644 100644 488bfa362d e2a202c40c M	desktop/core/src/desktop/js/apps/notebook/snippet.js
:100644 100644 8c25665333 f1700a6a7e M	desktop/core/src/desktop/js/apps/notebook2/editorViewModel.js
:000000 100644 0000000000 4290f8a189 A	desktop/core/src/desktop/js/apps/notebook2/executableStatement.js
:000000 100644 0000000000 44f7f8df53 A	desktop/core/src/desktop/js/apps/notebook2/executor.js
:100644 100644 bc33a353df 3dd0d606c4 M	desktop/core/src/desktop/js/apps/notebook2/notebook.js
:100644 100644 ec9f7fc299 5f6c0858f3 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:000000 100644 0000000000 0f7d15c8f9 A	desktop/core/src/desktop/js/apps/notebook2/spec/executableStatementSpec.js
:000000 100644 0000000000 657012e832 A	desktop/core/src/desktop/js/apps/notebook2/spec/executorSpec.js
:100644 100644 649416639d 363f0a0207 M	desktop/core/src/desktop/js/hue.js
:000000 100644 0000000000 640d96da19 A	desktop/core/src/desktop/js/parse/parserTypeDefs.js
:100644 100644 9f2e113731 d6878fc5e1 M	desktop/core/src/desktop/js/parse/sqlStatementsParser.js
:100644 100644 f5ad84e86d dacb0d2a41 M	package-lock.json
:100644 100644 a83442d137 0394b1bd10 M	package.json
:100644 100644 a9f01a0045 94dab3ba32 M	tools/jison/generateParsers.js

commit 728a973138943ca3c249ac8b102bda9d378e7337
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu Mar 28 12:47:55 2019 +0100

    HUE-8768 [editor] Improve notebook and view model structure for notebook 2

:100644 100644 9d3ebb5144 0ef6e0e83f M	desktop/core/src/desktop/js/apps/notebook/editorViewModel.js
:100644 100644 8bcdfc53df 01826d4d32 M	desktop/core/src/desktop/js/apps/notebook/notebook.js
:100644 100644 224e1149fe 488bfa362d M	desktop/core/src/desktop/js/apps/notebook/snippet.js
:100644 100644 f6a9079d71 8c25665333 M	desktop/core/src/desktop/js/apps/notebook2/editorViewModel.js
:100644 100644 a0f8fff1d8 bc33a353df M	desktop/core/src/desktop/js/apps/notebook2/notebook.js
:100644 100644 d56307d56b 710d00687c M	desktop/core/src/desktop/js/apps/notebook2/result.js
:100644 100644 c44504a6ec 352694961d M	desktop/core/src/desktop/js/apps/notebook2/session.js
:100644 100644 c52e700ffd ec9f7fc299 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 c171420162 f5aa5e5f97 M	desktop/core/src/desktop/js/ko/components/ko.historyPanel.js

commit fcfc0b8277f101433b0e42abe27c5ecf506c34d6
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Mar 27 16:20:22 2019 +0100

    HUE-8768 [editor] Clean up the snippet model to prepare for notebook 2

:100644 100644 ea91749e41 854312361a M	apps/beeswax/src/beeswax/templates/execute.mako
:100644 100644 687f192c8d 224e1149fe M	desktop/core/src/desktop/js/apps/notebook/snippet.js
:100644 100644 7380c6382d 241e5d81b8 M	desktop/core/src/desktop/js/apps/notebook/spec/aceAutocompleteWrapperSpec.js
:100644 100644 2ad8c6a0bd f6a9079d71 M	desktop/core/src/desktop/js/apps/notebook2/editorViewModel.js
:100644 100644 bb76aa1cc2 a0f8fff1d8 M	desktop/core/src/desktop/js/apps/notebook2/notebook.js
:100644 100644 37fbb44d55 c52e700ffd M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 588d34eeda 57c90d1d82 M	desktop/core/src/desktop/js/ko/bindings/ko.aceResizer.js
:100644 100644 9254009c7f f889b6855e M	desktop/core/src/desktop/js/parse/spec/sqlAutocompleteParser_Locations_Spec.js
:100644 100644 5dd4828155 1a5a80f1b8 M	desktop/core/src/desktop/js/parse/sqlParseSupport.js
:100644 100644 f0d302e922 80fbdb7272 M	desktop/core/src/desktop/js/utils/spec/hdfsAutocompleterSpec.js
:100644 100644 138ad4d7e2 227c68ebb3 M	desktop/libs/notebook/src/notebook/templates/editor_components.mako

commit 09b2e86a929464b9cf777edbef36dbe1196b0a1b
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Mar 27 12:17:30 2019 +0100

    HUE-8768 [editor] Add a feature flag for notebook2
    
    [notebook]
      enable_notebook_2=true

:000000 100644 0000000000 2ad8c6a0bd A	desktop/core/src/desktop/js/apps/notebook2/editorViewModel.js
:000000 100644 0000000000 bb76aa1cc2 A	desktop/core/src/desktop/js/apps/notebook2/notebook.js
:000000 100644 0000000000 d56307d56b A	desktop/core/src/desktop/js/apps/notebook2/result.js
:000000 100644 0000000000 c44504a6ec A	desktop/core/src/desktop/js/apps/notebook2/session.js
:000000 100644 0000000000 37fbb44d55 A	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 a279f5ff7a 649416639d M	desktop/core/src/desktop/js/hue.js
:100644 100644 cd63797357 442eabe71d M	desktop/core/src/desktop/templates/global_js_constants.mako
:100644 100644 44062ab1c8 6db0924002 M	desktop/libs/notebook/src/notebook/conf.py

Manual on Chrome + Jasmine

It's still WIP and currently at the point where it uses the new executor and displays the result. What's left to do is:

  1. Progress indication
  2. Logs
  3. Session management and properties
  4. UI modifications to better support execution flow
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
  1. Nice! Getting there!

  2. 
      
  1. 
      
  2. We should probably align on Promise vs $.Deferred. Switching between both increases complexity.

    1. Agreed. Promise is the way to go but in some cases it's not trivial until we refactor CancellablePromise to use/extend Promise.

  3. 
      
Review request changed

Status: Closed (submitted)

Loading...