HUE-8747 [editor] Handle empty result sets in tasks.

Review Request #13837 - Created April 16, 2019 and submitted

Jean-Francois Desjeans Gauthier
hue
master
HUE-8747
hue
jgauthier
commit 3a6f7887476f3888888cb9c77325a9d993cd0032
Author: jdesjean <jgauthier@cloudera.com>
Date:   Tue Apr 16 14:24:29 2019 -0700

    HUE-8747 [editor] Handle empty result sets in tasks.

:100644 100644 327a5bb795... 6b5febae50... M	desktop/libs/notebook/src/notebook/tasks.py


  • 0
  • 0
  • 3
  • 0
  • 3
Description From Last Updated
  1. A few nits to simplify a bit

  2. Could we move within the if?

  3. nit:

    split_type = split[1] if len(split) > 1 else 'STRING_TYPE'

    then no repetition in cols.append()

    nit: should also be gone when we use a proper serialization format later

  4. Could we move within the if of #266?

    'info.get('has_result_set', False) and' not needed then

  5. 
      
Review request changed

Status: Closed (submitted)

Loading...