HUE-8750 [core] Add ProxyMiddleware for user

Review Request #13926 - Created May 2, 2019 and updated

Jean-Francois Desjeans Gauthier
hue
master
HUE-8750
hue
jgauthier
commit 4b4caf7249429798798c1a03e8f2b0f072a5c354
Author: jdesjean <jgauthier@cloudera.com>
Date:   Thu May 2 13:27:52 2019 -0700

    HUE-8750 [core] Add ProxyMiddleware for user.name GET param

:100644 100644 9c57e555c5... 2cdf689e68... M	desktop/core/src/desktop/middleware.py
:100644 100644 0b3ae8a579... 25cd90e6d4... M	desktop/core/src/desktop/settings.py


  • 0
  • 0
  • 0
  • 4
  • 4
Description From Last Updated
  1. 
      
  2. desktop/core/src/desktop/middleware.py (Diff revision 1)
     
     

    Might make sense to check if user is logged in first.

  3. 
      
  1. 
      
    1. The idea here is to add this proxy for Knox with no security. Useful for debugging.

  2. desktop/core/src/desktop/middleware.py (Diff revision 1)
     
     

    Add a description about when to use it?
    Also add in ini too?

    1. Right now it's specific to the AllowAllBackend and not configurable. Does that make sense?

  3. desktop/core/src/desktop/middleware.py (Diff revision 1)
     
     

    AllowAllBackend --> ProxyMiddleware?

    1. The idea here is that if you use AllowAllBackend i.e. no authentication, then we accept the username from the URL.

  4. desktop/core/src/desktop/middleware.py (Diff revision 1)
     
     

    Do we expect to have users created before with a blank password? How secure is it BTW if we just trust username from GET param?

    1. AllowAllBackend creates the user if it doesn't exists.

  5. 
      
  1. Could we put all above comments as code comments?
    (as difficult to guess)

  2. 
      
Loading...