HUE-8737 [core] Initial python 3 support

Review Request #13941 - Created May 10, 2019 and updated

Ying Chen
hue
ying-django
HUE-8737
hue
jgauthier, johan, ranade, romain, weixia
commit 4c2d9b41d85025929557782240a41fc81a527132
Author: Ying Chen <yingchen@cloudera.com>
Date:   Fri May 10 08:41:29 2019 -0700

    [core] make Hue can be built on both py2 and py3

:100644 100644 ee789b3... 6f0aee2... M	Makefile.vars
1. Not done yet, need to check py3 Python.h and create requirement.txt for both python version.
2. allow python version to 2.7 and 3.5
  • 0
  • 0
  • 7
  • 0
  • 7
Description From Last Updated
  1. Nice!

    How about keeping it shorter by reusing the same logic as before?

  2. Makefile.vars (Diff revision 1)
     
     

    IS HUE_PYTHON_VERSION a new variable of the official one used in other parts already?

  3. Makefile.vars (Diff revision 1)
     
     

    This looks incorrect as not in sync with master?

  4. Makefile.vars (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Would it make sense to default
    HUE_PYTHON_VERSION to 2.7
    and have everything else in common?

    Final check would be 2.7 or > 3.5.

  5. 
      
  1. 
      
  2. Makefile.vars (Diff revision 2)
     
     

    Could we make it Python >= 3.5, not just 3.5?

  3. 
      
  1. 
      
  2. Makefile.vars (Diff revision 2)
     
     

    Do reverse

    ifeq ($(PYTHON_VER),python2.7)

    else ifeq ($(PYTHON_VER),python3.5)

    else ifeq ($(PYTHON_VER),)

    else

  3. Makefile.vars (Diff revision 2)
     
     

    I think you should split just like above.

  4. Makefile.vars (Diff revision 2)
     
     

    I think this should be the first if condition.

  5. 
      
Review request changed
Loading...