Adding knox trusted proxy authentication in Hue

Review Request #13943 - Created May 10, 2019 and updated May 13, 2019, 5:17 p.m.

Information
Owner:	Prakash Ranade
Repository:	hue
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	hue
People:	jgauthier, johan, ranade, romain, subrata, weixia, yingc

Description

commit cf14f21a2ca8cea0595c81b25e6e1d509f5394f5
Author: Prakash Ranade <ranade@cloudera.com>
Date:   Fri May 10 18:02:26 2019 -0700

    Adding knox trusted proxy authentication in Hue

:100644 100644 129e022adc 8d7b0bcf27 M	desktop/conf.dist/hue.ini
:100644 100644 a84c64de71 0759546844 M	desktop/core/src/desktop/auth/backend.py
:100644 100644 ddb2723b39 9cbcf9f8f7 M	desktop/core/src/desktop/conf.py
:100644 100644 9c57e555c5 c6cb8e1f29 M	desktop/core/src/desktop/middleware.py

Testing Done

Limited testing done. Need to test with end-to-end Hue setup where Knox re-write rules are working.

Issues

0
0
5
1
All Issues: 6

Description	From	Last Updated
Also sync https://github.com/cloudera/hue/blob/master/desktop/conf/pseudo-distributed.ini.tmpl ?	Romain Rigaux	May 13, 2019, 5:07 p.m.
Remove 'CDPD'? (unrelated to Knox itself)	Romain Rigaux	May 13, 2019, 5:07 p.m.
Used?	Romain Rigaux	May 13, 2019, 5:10 p.m.
nit: Remove 'len()'?	Romain Rigaux	May 13, 2019, 5:11 p.m.
if not knox_verification:	Romain Rigaux	May 13, 2019, 5:12 p.m.
return set([h.split(':')[0] for h in pattern.split(',')] ?	Romain Rigaux	May 13, 2019, 5:14 p.m.

Ship it!

```
Nice!
```

desktop/conf.dist/hue.ini (Diff revision 1)

Show all issues

Also sync https://github.com/cloudera/hue/blob/master/desktop/conf/pseudo-distributed.ini.tmpl
?

desktop/core/src/desktop/conf.py (Diff revision 1)
Show all issues
```
Remove 'CDPD'?
(unrelated to Knox itself)
```

desktop/core/src/desktop/middleware.py (Diff revision 1)

Show all issues

Used?

Prakash Ranade May 13, 2019, 5:17 p.m.

used on line 640. This change has missed it. https://github.com/cloudera/hue/commit/e33989453cee940467f2436a5a530b9c485c0c3e

desktop/core/src/desktop/middleware.py (Diff revision 1)
Show all issues
```
nit: Remove 'len()'?
```
desktop/core/src/desktop/middleware.py (Diff revision 1)
Show all issues
```
if not knox_verification:
```

desktop/core/src/desktop/middleware.py (Diff revision 1)

Show all issues

return set([h.split(':')[0] for h in pattern.split(',')]
?

Prakash Ranade May 13, 2019, 5:17 p.m.

Knox service can have more than one knox proxy. This check is used if more than one proxies are defined in hue.ini

You have a pending review.

Review Board 3.0.3

Adding knox trusted proxy authentication in Hue