Adding knox trusted proxy authentication in Hue

Review Request #13943 - Created May 10, 2019 and updated

Prakash Ranade
hue
master
hue
jgauthier, johan, ranade, romain, subrata, weixia, yingc
commit cf14f21a2ca8cea0595c81b25e6e1d509f5394f5
Author: Prakash Ranade <ranade@cloudera.com>
Date:   Fri May 10 18:02:26 2019 -0700

    Adding knox trusted proxy authentication in Hue

:100644 100644 129e022adc 8d7b0bcf27 M	desktop/conf.dist/hue.ini
:100644 100644 a84c64de71 0759546844 M	desktop/core/src/desktop/auth/backend.py
:100644 100644 ddb2723b39 9cbcf9f8f7 M	desktop/core/src/desktop/conf.py
:100644 100644 9c57e555c5 c6cb8e1f29 M	desktop/core/src/desktop/middleware.py

Limited testing done. Need to test with end-to-end Hue setup where Knox re-write rules are working.

  • 0
  • 0
  • 5
  • 1
  • 6
Description From Last Updated
  1. Nice!

  2. desktop/conf.dist/hue.ini (Diff revision 1)
     
     

    Also sync https://github.com/cloudera/hue/blob/master/desktop/conf/pseudo-distributed.ini.tmpl
    ?

  3. desktop/core/src/desktop/conf.py (Diff revision 1)
     
     

    Remove 'CDPD'?

    (unrelated to Knox itself)

    1. used on line 640. This change has missed it. https://github.com/cloudera/hue/commit/e33989453cee940467f2436a5a530b9c485c0c3e

  4. desktop/core/src/desktop/middleware.py (Diff revision 1)
     
     
     
     

    nit: Remove 'len()'?

  5. desktop/core/src/desktop/middleware.py (Diff revision 1)
     
     

    if not knox_verification:

  6. desktop/core/src/desktop/middleware.py (Diff revision 1)
     
     
     
     

    return set([h.split(':')[0] for h in pattern.split(',')]

    ?

    1. Knox service can have more than one knox proxy. This check is used if more than one proxies are defined in hue.ini

  7. 
      
Loading...