HUE-8836 [core] request.get_host() is broken when HTTP_X_FORWARDED_HOST contains multiple hosts

Review Request #13948 — Created May 13, 2019 and updated May 14, 2019, 1:05 p.m.

Information
Owner:	ranade
Repository:	hue
Branch:
Bugs:
Depends On:
Reviewers
Groups:	hue
People:	jgauthier, johan, ranade, romain, subrata, weixia, yingc

Description

HUE-8836 [core] request.get_host() is broken when HTTP_X_FORWARDED_HOST contains multiple hosts

Testing Done

Tested on Browser --> Knox Proxy --> Hue Load Balancer --> Hue server. Working fine.

Issues

0
0
0
1
All Issues: 1

Description	From	Last Updated
Nice, just instead of modifying Django code directly, could we use a middleware? Seems like an official solution? https://github.com/django/django/commit/6e201bcae2 https://code.djangoproject.com/ticket/11877 ...	romain	May 14, 2019, 9:50 a.m.

desktop/core/ext-py/Django-1.11.20/django/http/request.py (Diff revision 1)

Show all issues

Nice, just instead of modifying Django code directly, could we use a middleware?

Seems like an official solution? https://github.com/django/django/commit/6e201bcae2

https://code.djangoproject.com/ticket/11877
https://code.djangoproject.com/ticket/20303

ranade May 14, 2019, 9:51 a.m.

I think this middleware approach is controversial. As you see in the end, it changes the value of request.META[field]. My approach does not make any modification


request.META[field] = parts[-1].strip()

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 3.0.18

HUE-8836 [core] request.get_host() is broken when HTTP_X_FORWARDED_HOST contains multiple hosts