HUE-8750 [editor] Add knox service definition.

Review Request #13953 - Created May 15, 2019 and updated

Jean-Francois Desjeans Gauthier
hue
master
HUE-8750
hue
jgauthier
commit bf0e01dc1bf6bc583d31d8042b76f4c605776eb3
Author: jdesjean <jgauthier@cloudera.com>
Date:   Mon May 13 16:26:23 2019 -0700

    HUE-8750 [core] Add Knox service definition.

:100644 100644 230f21519c... c997bbf772... M	apps/about/src/about/templates/admin_wizard.mako
:100644 100644 a892a52ac4... 3dee5dba13... M	apps/about/src/about/urls.py
:100644 100644 373415c957... 4e85f28b2d... M	apps/beeswax/src/beeswax/static/beeswax/js/beeswax.vm.js
:100644 100644 854312361a... 5096382863... M	apps/beeswax/src/beeswax/templates/execute.mako
:100644 100644 5da8bf86e8... d2e31f5517... M	apps/beeswax/src/beeswax/urls.py
:100644 100644 1c84c7fa66... f48faca529... M	apps/filebrowser/src/filebrowser/templates/display.mako
:100644 100644 4b10eba451... 6ddf5978e1... M	apps/filebrowser/src/filebrowser/templates/listdir_components.mako
:100644 100644 3a7ad6bf96... 9a46af8336... M	apps/filebrowser/src/filebrowser/urls.py
:100644 100644 f288e7d817... 20eb1deb2a... M	apps/filebrowser/src/filebrowser/views.py
:100644 100644 344197f0d3... 79d8b92849... M	apps/hbase/src/hbase/urls.py
:100644 100644 9980d93876... cf49d97169... M	apps/help/src/help/urls.py
:100644 100644 8803b6ac7c... e20eb010bf... M	apps/jobbrowser/src/jobbrowser/urls.py
:100644 100644 b39660fab5... ba17587bb2... M	apps/jobsub/src/jobsub/urls.py
:100644 100644 1e9655a5a8... 298c823030... M	apps/metastore/src/metastore/urls.py
:100644 100644 6e546322d3... 423015b7b8... M	apps/oozie/src/oozie/urls.py
:100644 100644 12ebc60252... b33f42b859... M	apps/pig/src/pig/urls.py
:100644 100644 e961ff29ee... 53adcf5176... M	apps/rdbms/src/rdbms/urls.py
:100644 100644 82f101a951... 50929b01ce... M	apps/search/src/search/urls.py
:100644 100644 36b8c62abc... 18ff5efe2f... M	apps/sqoop/src/sqoop/urls.py
:100644 100644 c3a16f4349... fc4d782f97... M	apps/useradmin/src/useradmin/urls.py
:100644 100644 51335f3c62... 2995e11d93... M	apps/zookeeper/src/zookeeper/urls.py
:100644 100644 1b4caa9a3a... 5bcfac6cc0... M	desktop/core/src/desktop/js/apps/notebook/snippet.js
:100644 100644 35ddac4664... b1c49c6b76... M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 ac55903953... 50dd944dfc... M	desktop/core/src/desktop/js/ko/bindings/ko.hueLink.js
:100644 100644 554afff1bd... 6efa4b8128... M	desktop/core/src/desktop/js/onePageViewModel.js
:100644 100644 5a76fb951b... a35b36fe2a... M	desktop/core/src/desktop/js/sql/sqlWorkerHandler.js
:100644 100644 bee33531f3... d580d9bd8d... M	desktop/core/src/desktop/js/utils/hueUtils.js
:100644 100644 982ea35b7b... 029f14ff46... M	desktop/core/src/desktop/lib/django_mako.py
:100644 100644 25cd90e6d4... e9ef1767e5... M	desktop/core/src/desktop/settings.py
:100644 100644 d0390b21be... 598b7a9dee... M	desktop/core/src/desktop/static/desktop/js/document/hueFileEntry.js
:100644 100644 522fb5983b... 79caf44138... M	desktop/core/src/desktop/templates/ace_sql_location_worker.mako
:100644 100644 427fd02c67... 11740df211... M	desktop/core/src/desktop/templates/ace_sql_syntax_worker.mako
:100644 100644 f03b021bb0... e5aff6baac... M	desktop/core/src/desktop/templates/common_header.mako
:100644 100644 30d0379d0a... 1ee350ba23... M	desktop/core/src/desktop/templates/common_header_footer_components.mako
:100644 100644 029b81c5bd... 896c08964e... M	desktop/core/src/desktop/templates/common_header_m.mako
:100644 100644 df332bf5df... c57894554c... M	desktop/core/src/desktop/templates/common_notebook_ko_components.mako
:100644 100644 442eabe71d... 5887953759... M	desktop/core/src/desktop/templates/global_js_constants.mako
:100644 100644 2e30db88c4... bc60172f55... M	desktop/core/src/desktop/templates/hue.mako
:100644 100644 de712d5ec1... a4d9c86663... M	desktop/core/src/desktop/templates/logs.mako
:100644 100644 8a0a100a91... 1a9fed7fc1... M	desktop/core/src/desktop/urls.py
:100644 100644 51d870f35b... 9b89734805... M	desktop/libs/dashboard/src/dashboard/static/dashboard/js/collections.ko.js
:100644 100644 796a97960d... 8612fbd1d1... M	desktop/libs/dashboard/src/dashboard/urls.py
:100644 100644 2f7507c2d7... b035498dd4... M	desktop/libs/indexer/src/indexer/static/indexer/js/collections.js
:100644 100644 4eb74073f5... 3f8b569b4e... M	desktop/libs/indexer/src/indexer/static/indexer/js/indexes.ko.js
:100644 100644 9a5d517b22... 8eccdca696... M	desktop/libs/indexer/src/indexer/templates/importer.mako
:100644 100644 5fd34e11e1... ae00f67d0e... M	desktop/libs/indexer/src/indexer/urls.py
:100644 100644 200e363b4e... 15dad6d655... M	desktop/libs/notebook/src/notebook/templates/editor_m.mako
:000000 100644 0000000000... bc893e2efa... A	tools/knox/hue/1.0.0/rewrite.xml
:000000 100644 0000000000... 65529b9f48... A	tools/knox/hue/1.0.0/service.xml


  • 3
  • 0
  • 1
  • 1
  • 5
Description From Last Updated
Maybe adding note to http://cloudera.github.io/hue/latest/developer/development/#javascript to use huePubSub.publish('open.link'... and not location.href? Romain Rigaux
For each Hue app, aka first level URL prefix, we would need to add it here? Romain Rigaux
Shouldn't this be set from some py function? Can also skip the KNOX_BASE_URL altogether and just set HUE_BASE_URL from the ... Johan Åhlén
  1. Super nice!

  2. desktop/core/src/desktop/settings.py (Diff revision 1)
     
     

    Add as propery in desktop/conf.py and inis?

    Needed for STATIC_URL too?

    (we can see later to autoset it if there is the KnoxBackend)

    1. Added some knox rule so we don't have to deal with this anymore.

  3. Nit: comment that it is about HUE_BASE_URL global injection?

  4. Maybe adding note to http://cloudera.github.io/hue/latest/developer/development/#javascript to use huePubSub.publish('open.link'... and not location.href?

  5. tools/knox/hue/1.0.0/rewrite.xml (Diff revision 1)
     
     

    For each Hue app, aka first level URL prefix, we would need to add it here?

    1. Here's the challenge I'm facing. Knox needs to have /hue in all the URLS. Our html endpoints all have /hue, but our apis don't so we need a way to differenciate between the 2.
      Solution 1:
      We use /hue/hue for html endpoint and /hue for APIs. We'd need some changes in the router and this look a bit strange in the URL.
      Solution 2:
      We add the html endpoints in knox and handle the complexity there.

      There's no perfect solution.

  6. 
      
Review request changed
  1. 
      
  2. Shouldn't this be set from some py function?

    Can also skip the KNOX_BASE_URL altogether and just set HUE_BASE_URL from the conf or empty.

  3. 
      
Loading...