HUE-8737 [core] Initial python 3 support

Review Request #13989 - Created June 2, 2019 and updated

Ying Chen
hue
master
HUE-8737
hue
jgauthier, johan, ranade, romain, weixia
commit a717c8806a6321acc95a72e45d132deeb930c32b
Author: Ying Chen <yingchen@cloudera.com>
Date:   Sun Jun 2 01:23:30 2019 -0700

    [core] make Hue install third party libs via requirement.txt

:100644 100644 edebba1... 3284b99... M	desktop/core/Makefile
Step 1: not include Makefile.sdk if python3.x
Step 2: change env-install to pip install if python3.x
  • 4
  • 0
  • 0
  • 0
  • 4
Description From Last Updated
Should we do just one ifn ($(PYTHON_VER),python2.7) here instead? Romain Rigaux
Move to line 31? Romain Rigaux
Could we still add the if there, the Makefile is going to be even more difficult to understand if we ... Romain Rigaux
For info, is there a reason we can't do a regular if without back ticks? (because we are in the ... Romain Rigaux
  1. 
      
  2. desktop/core/Makefile (Diff revision 1)
     
     

    Should we do just one

    ifn ($(PYTHON_VER),python2.7)

    here instead?

  3. 
      
Review request changed

Change Summary:

getting started with step 2

Branch:

-ying-django
+master

Diff:

Revision 2 (+249 -4)

Show changes

  1. 
      
  2. desktop/core/Makefile (Diff revision 2)
     
     

    Move to line 31?

  3. desktop/core/Makefile (Diff revision 2)
     
     

    Could we still add the if there, the Makefile is going to be even more difficult to understand if we indirect things even more

  4. desktop/core/Makefile (Diff revision 2)
     
     
     
     
     
     
     
     

    For info, is there a reason we can't do a regular if without back ticks? (because we are in the tab indenteted instrution of a make target?)

  5. 
      
Loading...