HUE-8893 [assist] Lazy load all the left assist panels

Review Request #14056 — Created July 1, 2019 and submitted

johan
hue
master
hue
jgauthier, ranade, romain, roohi, weixia, yingc
commit 5960d4e9893ef74f768f98f3c7123b1d9f3143b9
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Mon Jul 1 14:00:31 2019 +0200

    HUE-8893 [assist] Lazy load all the left assist panels

:100644 100644 3d3f9bec87 76fd1b1d10 M	desktop/core/src/desktop/js/ko/components/assist/ko.assistAdlsPanel.js
:100644 100644 0e49274753 a389b34227 M	desktop/core/src/desktop/js/ko/components/assist/ko.assistDbPanel.js
:100644 100644 c6136fb961 235f64b2ac M	desktop/core/src/desktop/js/ko/components/assist/ko.assistDocumentsPanel.js
:100644 100644 a6c281c234 be66f91354 M	desktop/core/src/desktop/js/ko/components/assist/ko.assistGitPanel.js
:100644 100644 841ca5fa11 714c5b098f M	desktop/core/src/desktop/js/ko/components/assist/ko.assistHBasePanel.js
:100644 100644 3440d02cfb e711d788f2 M	desktop/core/src/desktop/js/ko/components/assist/ko.assistHdfsPanel.js
:100644 100644 b66e2bab0a a60bc17636 M	desktop/core/src/desktop/js/ko/components/assist/ko.assistPanel.js
:100644 100644 52a5f3d8b0 78ed809ec2 M	desktop/core/src/desktop/js/ko/components/assist/ko.assistS3Panel.js

commit 776148d86e218f5599c27a9cf4ff2a3ed84a3c23
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Fri Jun 28 15:55:16 2019 +0200

    HUE-8893 [assist] Extract all the left assist panels to ko components
    
    This also gets rid of all the mako inline python from these assist panels.

:100644 000000 41c593c1a9 0000000000 D	desktop/core/src/desktop/js/assist/assistAdlsPanel.js
:100644 000000 c73a87b5a8 0000000000 D	desktop/core/src/desktop/js/assist/assistDbPanel.js
:100644 000000 e4324d5e44 0000000000 D	desktop/core/src/desktop/js/assist/assistDocumentsPanel.js
:100644 000000 39eeddec77 0000000000 D	desktop/core/src/desktop/js/assist/assistGitPanel.js
:100644 000000 4c0149c8ea 0000000000 D	desktop/core/src/desktop/js/assist/assistHBasePanel.js
:100644 000000 77902575f6 0000000000 D	desktop/core/src/desktop/js/assist/assistHdfsPanel.js
:100644 000000 41c593c1a9 0000000000 D	desktop/core/src/desktop/js/assist/assistPanel.js
:100644 000000 434f879607 0000000000 D	desktop/core/src/desktop/js/assist/assistS3Panel.js
:100644 000000 076f5f6f56 0000000000 D	desktop/core/src/desktop/js/assist/ko/ko.assistPanel.js
:100644 100644 d5edb4a446 3eef7c376d M	desktop/core/src/desktop/js/hue.js
:100644 100644 ee90e9d139 9cedb13378 R093	desktop/core/src/desktop/js/assist/ko/ko.assistFileDraggable.js	desktop/core/src/desktop/js/ko/bindings/ko.assistFileDraggable.js
:100644 100644 a9513cd5c4 a9513cd5c4 R100	desktop/core/src/desktop/js/assist/ko/ko.assistFileDroppable.js	desktop/core/src/desktop/js/ko/bindings/ko.assistFileDroppable.js
:100644 100644 527ee97cc0 c5d9842c95 M	desktop/core/src/desktop/js/ko/bindings/ko.storageContextPopover.js
:100644 100644 8da6519da5 8da6519da5 R100	desktop/core/src/desktop/js/assist/assistDbEntry.js	desktop/core/src/desktop/js/ko/components/assist/assistDbEntry.js
:100644 100644 e52ef3e242 66b8a77b67 R099	desktop/core/src/desktop/js/assist/assistDbNamespace.js	desktop/core/src/desktop/js/ko/components/assist/assistDbNamespace.js
:100644 100644 041e6950e5 516cf0d4bd R099	desktop/core/src/desktop/js/assist/assistDbSource.js	desktop/core/src/desktop/js/ko/components/assist/assistDbSource.js
:100644 100644 aaabc646df aaabc646df R100	desktop/core/src/desktop/js/assist/assistGitEntry.js	desktop/core/src/desktop/js/ko/components/assist/assistGitEntry.js
:100644 100644 37e477e0da 37e477e0da R100	desktop/core/src/desktop/js/assist/assistHBaseEntry.js	desktop/core/src/desktop/js/ko/components/assist/assistHBaseEntry.js
:100644 100644 2a7d9ef54d 3f759f61af R095	desktop/core/src/desktop/js/assist/assistInnerPanel.js	desktop/core/src/desktop/js/ko/components/assist/assistInnerPanel.js
:100644 100644 ed0644e61e ed0644e61e R100	desktop/core/src/desktop/js/assist/assistStorageEntry.js	desktop/core/src/desktop/js/ko/components/assist/assistStorageEntry.js
:100644 100644 bd6a819982 b194622465 R068	desktop/core/src/desktop/js/assist/assistViewModel.js	desktop/core/src/desktop/js/ko/components/assist/assistViewModel.js
:000000 100644 0000000000 3d3f9bec87 A	desktop/core/src/desktop/js/ko/components/assist/ko.assistAdlsPanel.js
:000000 100644 0000000000 0e49274753 A	desktop/core/src/desktop/js/ko/components/assist/ko.assistDbPanel.js
:000000 100644 0000000000 c6136fb961 A	desktop/core/src/desktop/js/ko/components/assist/ko.assistDocumentsPanel.js
:000000 100644 0000000000 a6c281c234 A	desktop/core/src/desktop/js/ko/components/assist/ko.assistGitPanel.js
:000000 100644 0000000000 841ca5fa11 A	desktop/core/src/desktop/js/ko/components/assist/ko.assistHBasePanel.js
:000000 100644 0000000000 3440d02cfb A	desktop/core/src/desktop/js/ko/components/assist/ko.assistHdfsPanel.js
:000000 100644 0000000000 b66e2bab0a A	desktop/core/src/desktop/js/ko/components/assist/ko.assistPanel.js
:000000 100644 0000000000 52a5f3d8b0 A	desktop/core/src/desktop/js/ko/components/assist/ko.assistS3Panel.js
:100644 100644 f31e0228d8 68e154ce2d M	desktop/core/src/desktop/js/ko/components/contextPopover/storageContext.js
:100644 100644 d797948d9f c51f3b67a9 M	desktop/core/src/desktop/js/ko/ko.all.js
:100644 100644 aa0a35ec77 edfb369f0a M	desktop/core/src/desktop/js/sql/aceLocationHandler.js
:100644 100644 cbe60fda85 3a4a2a7b09 M	desktop/core/src/desktop/templates/assist.mako
:100644 100644 79c6473c02 392c913417 M	desktop/core/src/desktop/templates/global_js_constants.mako

commit fc8bb479a91468df7aa437484875cef8238d91fa
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu Jun 27 11:15:10 2019 +0200

    HUE-8893 [assist] Move the remaining assist subpanels into webpack

:000000 100644 0000000000 41c593c1a9 A	desktop/core/src/desktop/js/assist/assistAdlsPanel.js
:000000 100644 0000000000 e4324d5e44 A	desktop/core/src/desktop/js/assist/assistDocumentsPanel.js
:000000 100644 0000000000 39eeddec77 A	desktop/core/src/desktop/js/assist/assistGitPanel.js
:000000 100644 0000000000 4c0149c8ea A	desktop/core/src/desktop/js/assist/assistHBasePanel.js
:000000 100644 0000000000 77902575f6 A	desktop/core/src/desktop/js/assist/assistHdfsPanel.js
:000000 100644 0000000000 41c593c1a9 A	desktop/core/src/desktop/js/assist/assistPanel.js
:000000 100644 0000000000 434f879607 A	desktop/core/src/desktop/js/assist/assistS3Panel.js
:000000 100644 0000000000 076f5f6f56 A	desktop/core/src/desktop/js/assist/ko/ko.assistPanel.js
:100644 100644 070c62bbac d5edb4a446 M	desktop/core/src/desktop/js/hue.js
:100644 100644 b6b40c086f cbe60fda85 M	desktop/core/src/desktop/templates/assist.mako

commit 67f9cb5959fbdfe7db7c527d0cfb263151a58be6
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Jun 26 17:10:40 2019 +0200

    HUE-8893 [assist] Move AssistDbPanel, AssistInnerPanel and assist specific ko bindings to webpack

:000000 100644 0000000000 c73a87b5a8 A	desktop/core/src/desktop/js/assist/assistDbPanel.js
:000000 100644 0000000000 2a7d9ef54d A	desktop/core/src/desktop/js/assist/assistInnerPanel.js
:000000 100644 0000000000 ee90e9d139 A	desktop/core/src/desktop/js/assist/ko/ko.assistFileDraggable.js
:000000 100644 0000000000 a9513cd5c4 A	desktop/core/src/desktop/js/assist/ko/ko.assistFileDroppable.js
:100644 100644 caa0ff8c95 070c62bbac M	desktop/core/src/desktop/js/hue.js
:100644 100644 dc067518cf b6b40c086f M	desktop/core/src/desktop/templates/assist.mako
:100644 100644 c20e61f59f 79c6473c02 M	desktop/core/src/desktop/templates/global_js_constants.mako

commit a64e155abbbf103d53b20ad4c17e5470fbeba74e
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Jun 26 16:09:52 2019 +0200

    HUE-8893 [assist] Move HueDocument and HueFileEntry into webpack

:100644 100644 116d208604 abd5f684d5 M	apps/beeswax/src/beeswax/templates/create_database.mako
:100644 100644 db2b36f48b 6265f1fdf4 M	apps/beeswax/src/beeswax/templates/create_table_manually.mako
:100644 100644 5096382863 e0e83f857b M	apps/beeswax/src/beeswax/templates/execute.mako
:100644 100644 c1da1e0700 29fef5af13 M	apps/beeswax/src/beeswax/templates/import_wizard_choose_delimiter.mako
:100644 100644 989a634176 84e79ceb34 M	apps/beeswax/src/beeswax/templates/import_wizard_choose_file.mako
:100644 100644 78b00a8257 df7bf0d45a M	apps/beeswax/src/beeswax/templates/import_wizard_define_columns.mako
:100644 100644 8471bf86aa 7bdb4dcfa2 M	apps/jobbrowser/src/jobbrowser/templates/job_browser.mako
:100644 100644 7dc8f52449 c254ea7633 M	apps/metastore/src/metastore/templates/metastore.mako
:000000 100644 0000000000 ac426eb0d7 A	desktop/core/src/desktop/js/doc/hueDocument.js
:000000 100644 0000000000 6e431b6688 A	desktop/core/src/desktop/js/doc/hueFileEntry.js
:100644 100644 363f0a0207 caa0ff8c95 M	desktop/core/src/desktop/js/hue.js
:100644 100644 b125374d24 dc067518cf M	desktop/core/src/desktop/templates/assist.mako
:100644 100644 18204aa086 2568e2f54d M	desktop/core/src/desktop/templates/assist_m.mako
:100644 100644 56660191ff 16d4f085e4 M	desktop/core/src/desktop/templates/home2.mako
:100644 100644 36bda35d16 9fd3322b3f M	desktop/core/src/desktop/templates/hue.mako
:100644 100644 f47ebfd925 002cdd209e M	desktop/libs/indexer/src/indexer/templates/importer.mako
:100644 100644 53fec4baef 3a58a52ee2 M	desktop/libs/indexer/src/indexer/templates/indexer.mako
:100644 100644 140a652420 af15e2ee1f M	desktop/libs/indexer/src/indexer/templates/indexes.mako
:100644 100644 a3fb435cdd a9c758b14e M	desktop/libs/indexer/src/indexer/templates/topics.mako
:100644 100644 8b1dcff4d0 13033f3734 M	desktop/libs/notebook/src/notebook/templates/editor.mako
:100644 100644 15dad6d655 35346da943 M	desktop/libs/notebook/src/notebook/templates/editor_m.mako
:100644 100644 ba8dc37c25 d35b14422c M	desktop/libs/notebook/src/notebook/templates/notebook.mako

Manual on Chrome

Sorry about the size, it's a combination of move and a whole lot of refactoring hence the lack of proper diffs.

  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
jgauthier
  1. 
      
  2. Really hard to do any review with all the changes together.

  3. 
      
jgauthier
  1. Ship It!
  2. 
      
romain
  1. Ship It!
  2. 
      
johan
Review request changed

Status: Closed (submitted)

Loading...