HUE-8893 [tb] Create a separate table browser entry in webpack

Review Request #14078 - Created July 12, 2019 and submitted

Johan Åhlén
hue
master
hue
jgauthier, ranade, romain, roohi, weixia, yingc
commit 39e357011bd8e6f3b6608bd5e2bbff11b17b0786
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Fri Jul 12 11:48:49 2019 +0200

    HUE-8893 [tb] Create a separate table browser entry in webpack

:100644 100644 9b6d1c4e26 3c42b36f0f M	apps/beeswax/src/beeswax/templates/create_database.mako
:100644 100644 d29972dea4 097beb78d1 M	apps/beeswax/src/beeswax/templates/create_table_manually.mako
:100644 100644 718a8f3a63 23680b44b9 M	apps/beeswax/src/beeswax/templates/import_wizard_choose_delimiter.mako
:100644 100644 49125074d0 6b9f513117 M	apps/beeswax/src/beeswax/templates/import_wizard_choose_file.mako
:100644 100644 6cd0995272 216dde1ff8 M	apps/beeswax/src/beeswax/templates/import_wizard_define_columns.mako
:100644 100644 300faebaaf 43a37d770f M	apps/metastore/src/metastore/templates/metastore.mako
:100644 100644 a9e4066fdb 84dc9f1404 M	apps/useradmin/src/useradmin/templates/list_configurations.mako
:000000 100644 0000000000 689e84477d A	desktop/core/src/desktop/js/apps/table_browser/app.js
:100644 100644 1f7e827c7b e478c289ae M	desktop/core/src/desktop/js/hue.js
:100644 100644 41f65c5980 08f26c3779 M	desktop/core/src/desktop/templates/assist_m.mako
:100644 100644 95949323e7 b5faff73ad M	desktop/core/src/desktop/templates/common_header.mako
:100644 100644 64e61b966e 011a8776ff M	desktop/core/src/desktop/templates/global_js_constants.mako
:100644 100644 6d9465c758 fa5bc7b65f M	desktop/core/src/desktop/templates/hue.mako
:100644 100644 50415d2a3c 4c0c2e18ab M	desktop/libs/indexer/src/indexer/templates/importer.mako
:100644 100644 7efc1a6233 850355fb29 M	desktop/libs/indexer/src/indexer/templates/indexer.mako
:100644 100644 687dfc7911 50672913b6 M	webpack.config.js

commit 84ab82c27a65369ccb086d44743c32df29ac409e
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu Jul 11 15:32:26 2019 +0200

    HUE-8893 [tb] Extract the Table Browser view model to a webpack modules

:100644 000000 7dec0dc782 0000000000 D	apps/metastore/src/metastore/static/metastore/js/metastore.ko.js
:000000 100644 0000000000 2be5d45243 A	desktop/core/src/desktop/js/apps/table_browser/metastoreViewModel.js

commit 327be8d0a53e065a3941e9fafcff352805bd797c
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu Jul 11 15:31:35 2019 +0200

    HUE-8893 [tb] Extract Table Browser entity models to webpack modules

:100644 000000 a3736a3195 0000000000 D	apps/metastore/src/metastore/static/metastore/js/metastore.model.js
:000000 100644 0000000000 c3661aff16 A	desktop/core/src/desktop/js/apps/table_browser/metastoreColumn.js
:000000 100644 0000000000 720451aed5 A	desktop/core/src/desktop/js/apps/table_browser/metastoreDatabase.js
:000000 100644 0000000000 bbfaa67d54 A	desktop/core/src/desktop/js/apps/table_browser/metastoreNamespace.js
:000000 100644 0000000000 87bec7671f A	desktop/core/src/desktop/js/apps/table_browser/metastoreSource.js
:000000 100644 0000000000 f23c4dcd04 A	desktop/core/src/desktop/js/apps/table_browser/metastoreTable.js
:000000 100644 0000000000 e9a438857d A	desktop/core/src/desktop/js/apps/table_browser/metastoreTablePartitions.js
:000000 100644 0000000000 7dcef9593e A	desktop/core/src/desktop/js/apps/table_browser/metastoreTableSamples.js
Manual on Chrome
  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
  1. Nice jump in the decoupling!

    1. For now, there are still a few external libraries loaded in metastore.mako and once they're in webpack they'll end up in this file.

  2. For info, what it means when there is 'vendors' or not, and is notebook-tablebrowser something dedicated to the editor part?

    1. vendors is third-party libraries. Webpack creates the chunks automatically based on usage and the name of the files contains which bundles depend on it, so this particular one has third-party resources that hue (the main app), notebook and table browser needs.

      There are tooling to help with adding bundles to correct html files but with the current django mako situation we have to keep track of them and add them manually. Mainly it's when we introduce new "apps" into webpack.

  3. 
      
Review request changed

Status: Closed (submitted)

Loading...