HUE-8925 [fb] Fix config validation for Hive & AWS.

Review Request #14200 - Created Aug. 8, 2019 and submitted

Jean-Francois Desjeans Gauthier
hue
master
HUE-8925
hue
jgauthier, romain, yingc
commit bb6fd65fc9ef8ff3bf962d81bc11aec7d2f346cd
Author: Jean-Francois Desjeans Gauthier <jf.desjeans.gauthier@gmail.com>
Date:   Wed Aug 7 15:27:05 2019 -0700

    HUE-8925 [fb] Fix config validation for Hive & AWS.

:100644 100644 519faeea75... 0a45d0c6a3... M	apps/hive/src/hive/conf.py
:100644 100644 4c53918869... aea95beabd... M	desktop/core/src/desktop/lib/fs/proxyfs.py
:100644 100644 d20f45a872... 72df2ed3e4... M	desktop/libs/aws/src/aws/conf.py
:100644 100644 17d8ed83d2... bb7a15e2a7... M	desktop/libs/liboozie/src/liboozie/conf.py


  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
  1. 
      
  2. desktop/core/src/desktop/lib/fs/proxyfs.py (Diff revision 1)
     
     
     
     
     
    Is there a way to reuse _get_fs(self, path):?
    1. Problem is _get_fs checks if you have access and the user needs to be set; I can create new method

    2. +1 and can be reused in _get_fs(self, path).
      Easier to mock/test too

  3. 
      
  1. Nice!

  2. desktop/core/src/desktop/lib/fs/proxyfs.py (Diff revision 2)
     
     
     
     
     
     

    nit: could one line those 4

  3. 
      
Review request changed

Status: Closed (submitted)

Loading...