HUE-8768 [editor] Extract session handling from the editor view model

Review Request #14260 - Created Aug. 28, 2019 and updated

Johan Åhlén
hue
master
hue
jgauthier, ranade, romain, roohi, weixia, yingc
commit 6964713506b8c8161dca6959c9eb9a7d8571d77e
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Aug 28 14:22:23 2019 +0200

    HUE-8768 [editor] Extract session handling from the editor view model

:100644 100644 1e60e2ca4e a16c21fb2c M	desktop/core/src/desktop/js/api/apiHelper.js
:100644 100644 3837882020 6aa7a23fb9 M	desktop/core/src/desktop/js/apps/notebook/editorViewModel.js
:100644 100644 e30f987108 232610f45c M	desktop/core/src/desktop/js/apps/notebook2/editorViewModel.js
:100644 100644 338535972e 7b6ef87871 M	desktop/core/src/desktop/js/apps/notebook2/execution/executableStatement.js
:100644 100644 8dbfb1d41b 04f191761d M	desktop/core/src/desktop/js/apps/notebook2/execution/executor.js
:100644 100644 0c9d96a584 96c6d70980 M	desktop/core/src/desktop/js/apps/notebook2/execution/sessionManager.js
:100644 100644 bbcc45db62 215384023e M	desktop/core/src/desktop/js/apps/notebook2/notebook.js
:100644 100644 09ea860850 3eb62ab012 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 014e8636e9 7b3d51064f M	desktop/core/src/desktop/js/hue.js
:000000 100644 0000000000 52c859a66c A	desktop/core/src/desktop/js/ko/components/ko.sessionPanel.js
:100644 100644 789dfe51c3 594a731bda M	desktop/core/src/desktop/js/ko/ko.all.js
:100644 100644 331cd39c6e a3d3a752b4 M	desktop/core/src/desktop/js/onePageViewModel.js
:100644 100644 ba99f9c36c 7391d40699 M	desktop/core/src/desktop/static/desktop/css/hue.css
:100644 100644 9405883234 afd7ee5c53 M	desktop/core/src/desktop/static/desktop/less/hue4.less
:100644 100644 6adfb877b6 6bc9209109 M	desktop/core/src/desktop/templates/global_js_constants.mako
:100644 100644 6423072301 60db959275 M	desktop/core/src/desktop/templates/hue.mako
:100644 100644 88e5c14b7f 89edab811f M	desktop/libs/notebook/src/notebook/api.py
:100644 100644 213b8e0c18 10f16dca16 M	desktop/libs/notebook/src/notebook/templates/editor_components.mako
:100644 100644 3e329b9904 b9162f5c1d M	desktop/libs/notebook/src/notebook/templates/editor_components2.mako

commit 6ea2d6711a6b79c8dd58361b2515447923b644b0
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Aug 28 09:57:49 2019 +0200

    HUE-8768 [editor] Use ENABLE_NOTEBOOK_2 feature flag for split in editor html

:100644 100644 4b071c9bff 7f55beb770 M	desktop/libs/notebook/src/notebook/templates/editor.mako
:000000 100644 0000000000 3e329b9904 A	desktop/libs/notebook/src/notebook/templates/editor_components2.mako
:100644 100644 b09ea344a1 5331241029 M	desktop/libs/notebook/src/notebook/templates/notebook.mako

commit f9b7453c2609de11ef1255c5d4e7cebc9f0104ce
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Mon Aug 26 15:05:08 2019 +0200

    HUE-8768 [editor] Extract notebook and snippet ajax calls to ApiHelper

:100644 100644 f8b26af299 1e60e2ca4e M	desktop/core/src/desktop/js/api/apiHelper.js
:100644 100644 b1d1f2d19d bbcc45db62 M	desktop/core/src/desktop/js/apps/notebook2/notebook.js
:100644 100644 c9010b1978 09ea860850 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js

Manual on Chrome

Note that this is all behind feature flag ENABLE_NOTEBOOK_2

  1. Nice componentization!

    At the end, session properties there or gone? Know I remember people updating properties and doing a restart session in case of Hive / Spark.
    (could be tracker in jira back burner in epic)

    1. Properties are there, but only when use_default_configuration is set to true. I noticed that it's not possible to save the "default" configuration as the API endpoint doesn't exists so I guess no one actually did that.

  2. 
      
Loading...