HUE-8981 [editor] Extract the session authorization modal from the editor view model to a separate component

Review Request #14261 - Created Aug. 28, 2019 and updated

Johan Åhlén
hue
master
hue
jgauthier, ranade, romain, roohi, weixia, yingc
commit 8e2d999f6abceb1277434f34c3bbc0ff8d9951f8
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Aug 28 17:05:45 2019 +0200

    HUE-8981 [editor] Extract the session authorization modal from the editor view model to a separate component

:100644 100644 a16c21fb2c 0dd83c9398 M	desktop/core/src/desktop/js/api/apiHelper.js
:100644 100644 232610f45c 09c81b0de1 M	desktop/core/src/desktop/js/apps/notebook2/editorViewModel.js
:100644 100644 96c6d70980 b144d4894b M	desktop/core/src/desktop/js/apps/notebook2/execution/sessionManager.js
:100644 100644 a56fe5b36d a1b5503c3a M	desktop/core/src/desktop/js/apps/notebook2/execution/spec/executableStatementSpec.js
:000000 100644 0000000000 11bd93a2e1 A	desktop/core/src/desktop/js/apps/notebook2/execution/spec/sessionManagerSpec.js
:100644 000000 352694961d 0000000000 D	desktop/core/src/desktop/js/apps/notebook2/session.js
:100644 100644 dd6d980a80 5e8bc53659 M	desktop/core/src/desktop/js/ko/components/componentUtils.js
:100644 100644 594b721505 40e0830d09 M	desktop/core/src/desktop/js/ko/components/ko.createDirectoryModal.js
:100644 100644 ab199c919c 266cb9f46d M	desktop/core/src/desktop/js/ko/components/ko.deleteDocModal.js
:000000 100644 0000000000 95eed25086 A	desktop/core/src/desktop/js/ko/components/ko.sessionAuthModal.js
:100644 100644 594a731bda 23b784645e M	desktop/core/src/desktop/js/ko/ko.all.js
:100644 100644 b9162f5c1d 571a014029 M	desktop/libs/notebook/src/notebook/templates/editor_components2.mako
Manual on Chrome
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Review request changed

Change Summary:

Added jasmine tests for the sessionManager

Description:

~  

commit f261278fe97fbcb679321b5034d63c53c0d7b236

  ~

commit 8e2d999f6abceb1277434f34c3bbc0ff8d9951f8

    Author: Johan Ahlen johan@johanahlen.com
    Date: Wed Aug 28 17:05:45 2019 +0200

   
   
HUE-8981 [editor] Extract the session authorization modal from the editor view model to a separate component
   
~  

:100644 100644 a16c21fb2c 02af6f43fb M desktop/core/src/desktop/js/api/apiHelper.js

  ~

:100644 100644 a16c21fb2c 0dd83c9398 M desktop/core/src/desktop/js/api/apiHelper.js

    :100644 100644 232610f45c 09c81b0de1 M desktop/core/src/desktop/js/apps/notebook2/editorViewModel.js
~   :100644 100644 96c6d70980 de62350697 M desktop/core/src/desktop/js/apps/notebook2/execution/sessionManager.js
  ~ :100644 100644 96c6d70980 b144d4894b M desktop/core/src/desktop/js/apps/notebook2/execution/sessionManager.js
  + :100644 100644 a56fe5b36d a1b5503c3a M desktop/core/src/desktop/js/apps/notebook2/execution/spec/executableStatementSpec.js
  + :000000 100644 0000000000 11bd93a2e1 A desktop/core/src/desktop/js/apps/notebook2/execution/spec/sessionManagerSpec.js
    :100644 000000 352694961d 0000000000 D desktop/core/src/desktop/js/apps/notebook2/session.js
    :100644 100644 dd6d980a80 5e8bc53659 M desktop/core/src/desktop/js/ko/components/componentUtils.js
    :100644 100644 594b721505 40e0830d09 M desktop/core/src/desktop/js/ko/components/ko.createDirectoryModal.js
    :100644 100644 ab199c919c 266cb9f46d M desktop/core/src/desktop/js/ko/components/ko.deleteDocModal.js
    :000000 100644 0000000000 95eed25086 A desktop/core/src/desktop/js/ko/components/ko.sessionAuthModal.js
    :100644 100644 594a731bda 23b784645e M desktop/core/src/desktop/js/ko/ko.all.js
    :100644 100644 b9162f5c1d 571a014029 M desktop/libs/notebook/src/notebook/templates/editor_components2.mako

Diff:

Revision 2 (+382 -152)

Show changes

Loading...