HUE-8980 [jb] Fix coordinator cannot sync with saved documents

Review Request #14262 — Created Aug. 28, 2019 and submitted

yingc
hue
master
HUE-8980
hue
jgauthier, johan, romain, weixia
commit 4c8be479f22eed808c46f7e4451822215c1ffb68 (HEAD -> master)
Author: Ying Chen <yingchen@cloudera.com>
Date:   Tue Aug 27 15:21:05 2019 -0700

    HUE-8980 [jb] Fix coordinator cannot sync with saved documents

:100644 100644 0cdb9608ef... 7997cfa7b4... M    apps/jobbrowser/src/jobbrowser/templates/job_browser.mako
:100644 100644 46c7198013... d7cc668b32... M    apps/oozie/src/oozie/views/dashboard.py

test in progress

  • 0
  • 0
  • 16
  • 0
  • 16
Description From Last Updated
romain
  1. Nice!

    Hope one day we can componentized it well :)

  2. × --> [HTML_REMOVED]

  3. Internationalization of the strings?

  4. Yes --> No

    (or Cancel)

  5. apps/oozie/src/oozie/views/dashboard.py (Diff revision 1)
     
     

    Might not be TZ friendly but good for v1

  6. 
      
yingc
romain
  1. 
      
  2. () parenthesis not needed

  3. apps/jobbrowser/src/jobbrowser/templates/job_browser.mako (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     
     

    We show those only for coordinators? (not all the other type of jobs)

  4. apps/oozie/src/oozie/views/dashboard.py (Diff revision 2)
     
     
     

    Remove as ajax now?

  5. 
      
yingc
romain
  1. 
      
  2. apps/jobbrowser/src/jobbrowser/templates/job_browser.mako (Diff revision 3)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    Just glob all into a single
    
    <!-- ko if: $root.job() && $root.job().type() === 'schedule' -->
    
    ?
  3. 
      
yingc
yingc
Review request changed

Status: Closed (submitted)

Loading...