HUE-8983 [fb] Handle s3 with ListAllMyBuckets denied

Review Request #14264 — Created Aug. 28, 2019 and submitted

jgauthier
hue
master
HUE-8983
hue
jgauthier, johan, ranade, romain, weixia, yingc
commit b9dae18ba4b99b949f781ec656a6a36651e12032
Author: Jean-Francois Desjeans Gauthier <jf.desjeans.gauthier@gmail.com>
Date:   Wed Aug 28 12:59:13 2019 -0700

    HUE-8983 [fb] Handle s3 with ListAllMyBuckets denied

:100644 100644 ae33952a84... 5e844e19bd... M	apps/filebrowser/src/filebrowser/templates/listdir.mako
:100644 100644 59623d507e... faca826584... M	apps/filebrowser/src/filebrowser/templates/listdir_components.mako
:100644 100644 b729656ef5... 681ded6ede... M	apps/filebrowser/src/filebrowser/views.py
:100644 100644 08072b5a49... dce20bf7b7... M	desktop/libs/aws/src/aws/s3/s3fs.py


  • 0
  • 0
  • 3
  • 0
  • 3
Description From Last Updated
jgauthier
romain
  1. 
      
  2. desktop/libs/aws/src/aws/s3/s3fs.py (Diff revision 2)
     
     

    nit:

    Please specify... ?

    And I guess nothing specify about "buckets" in the S3 exception (to not conflict on other 403 errors)

  3. 
      
jgauthier
johan
  1. Ship It!
  2. ... or possibly rename this to self.errorMessage, to generify a bit.

  3. permission_error feels a bit too generic, perhaps "s3_listing_not_allowed": True/False?

    And custom message in the UI. You could still keep the permissionError observable and set the message if (s3_listing_not_allowed)...

  4. 
      
jgauthier
johan
  1. Ship It!
  2. 
      
jgauthier
Review request changed

Status: Closed (submitted)

Loading...