HUE-8988 [editor] Add export and import to query history tab

Review Request #14268 — Created Sept. 5, 2019 and submitted

johan
hue
master
hue
jgauthier, ranade, romain, roohi, weixia, yingc
commit be45d739bb456035d71f651dc5d420cead4ac07a
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu Sep 5 15:10:26 2019 -0700

    HUE-8988 [editor] Add export and import to query history tab
    
    The import and export actions are available in a right-click context menu on the query history tab.

:100644 100644 99d0dc011c c27f6b3140 M	desktop/core/src/desktop/api2.py
:100644 100644 0dd83c9398 3d483bb1d1 M	desktop/core/src/desktop/js/api/apiHelper.js
:100644 100644 a33bb8524d 659c3a587b M	desktop/core/src/desktop/js/apps/notebook/notebook.js
:100644 100644 8cfa1793b0 d84402cf85 M	desktop/core/src/desktop/js/apps/notebook/snippet.js
:100644 100644 215384023e 52efed832a M	desktop/core/src/desktop/js/apps/notebook2/notebook.js
:100644 100644 3eb62ab012 310457029b M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 10f16dca16 68d0d2f9a6 M	desktop/libs/notebook/src/notebook/templates/editor_components.mako
:100644 100644 571a014029 dd70e47503 M	desktop/libs/notebook/src/notebook/templates/editor_components2.mako

commit 215c5d9b014a74389f4a150fc30bdccac9578682
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu Sep 5 15:01:37 2019 -0700

    HUE-8988 [frontend] Extract import documents modal to a ko component

:100644 100644 6e431b6688 f527baa745 M	desktop/core/src/desktop/js/doc/hueFileEntry.js
:000000 100644 0000000000 a14a8bd0eb A	desktop/core/src/desktop/js/ko/components/ko.importDocumentsModal.js
:100644 100644 23b784645e 4054f89a7c M	desktop/core/src/desktop/js/ko/ko.all.js
:100644 000000 a038cb79a5 0000000000 D	desktop/core/src/desktop/static/desktop/js/document/hueDocument.js
:100644 000000 ed4de3cee0 0000000000 D	desktop/core/src/desktop/static/desktop/js/document/hueFileEntry.js
:100644 100644 af67d06518 7f07084e50 M	desktop/core/src/desktop/templates/document_browser.mako
:100644 100644 60db959275 d4903c30f5 M	desktop/core/src/desktop/templates/hue.mako

Manual on Chrome

https://dl.dropbox.com/s/kzgquoe4koy4gyo/Screenshot%202019-09-05%2015.10.39.png?dl=0

  • 0
  • 0
  • 1
  • 1
  • 2
Description From Last Updated
romain
  1. +1 to go like this for now until we do Query history v2 / Hue 5 restyling on 2 levels (Or: add new icon for export only, and import icon only in message when query history is empty).

    Curious if it is working when we have a query history of a saved query.

  2. Also add link to import in the "query history is empty" message?

  3. 
      
johan
romain
  1. 
      
  2. IIRC this is to keep the "Saved Query" tab selected when opening a doc from the left assist (to +1 to keep the behavior)

    1. Haha a bit hard to read that from the code... I'll add it back with comment and todo to reimplement properly.

  3. 
      
johan
Review request changed

Status: Closed (submitted)

Loading...