HUE-9001 [editor] Move snippet actions to underneath the editor in notebook 2

Review Request #14295 — Created Sept. 16, 2019 and submitted

johan
hue
hue
jgauthier, ranade, romain, roohi, weixia, yingc
commit a891b8d50f08af824b65ddfc627d7a7fd7d903bd
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Fri Sep 13 16:51:18 2019 +0200

    HUE-9001 [editor] Move snippet actions to underneath the editor in notebook 2

:100644 100644 8048f3ca47 30a8217811 M	desktop/core/src/desktop/js/apps/notebook/app.js
:100644 100644 15a44284b9 3f59c5aa96 M	desktop/core/src/desktop/static/desktop/css/hue.css
:100644 100644 f99eb9d08b a9f5fe107a M	desktop/core/src/desktop/static/desktop/css/hue3-extra.css
:100644 100644 66ed0d352e f6a9e3e719 M	desktop/core/src/desktop/static/desktop/less/components/hue-snippet-execute-actions.less
:100644 100644 7217483ac0 42f52cd73e M	desktop/libs/notebook/src/notebook/static/notebook/css/notebook.css
:100644 100644 59459b441c 8206d6f842 M	desktop/libs/notebook/src/notebook/static/notebook/less/notebook.less
:100644 100644 dd70e47503 7e6887e559 M	desktop/libs/notebook/src/notebook/templates/editor_components2.mako

commit 8577f879c768f520cd8c262971073827577ec88b
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Fri Sep 13 16:50:59 2019 +0200

    HUE-9001 [editor] Add ko component for controlling execution in notebook 2

:000000 100644 0000000000 e592d56138 A	desktop/core/src/desktop/js/apps/notebook2/components/ko.snippetExecuteButtonActions.js
:100644 100644 7b6ef87871 9f6ecac9ad M	desktop/core/src/desktop/js/apps/notebook2/execution/executableStatement.js
:100644 100644 665897de42 98350b9d14 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 ce565855a3 15a44284b9 M	desktop/core/src/desktop/static/desktop/css/hue.css
:100644 100644 1c47fa0e38 f99eb9d08b M	desktop/core/src/desktop/static/desktop/css/hue3-extra.css
:000000 100644 0000000000 66ed0d352e A	desktop/core/src/desktop/static/desktop/less/components/hue-snippet-execute-actions.less
:100644 100644 32e5c34e7c 0566def173 M	desktop/core/src/desktop/static/desktop/less/hue-cross-version.less

commit 58710bd875ad0526d448eb272b34d181ac10e3aa
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Fri Sep 13 16:49:05 2019 +0200

    HUE-9001 [editor] Improve executor logic in notebook 2 when failing

:100644 100644 310457029b 665897de42 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js

Manual on Chrome

For now just the execute button: https://dl.dropbox.com/s/z3atsrjktt3qgcc/Screenshot%202019-09-16%2016.05.55.png?dl=0

All behind enable_notebook_2 flag

romain
  1. Nice!

    +1 to combine all the execute option in a caret in the main button (cleaner as one less button and they are rarely used)!

    At some point we could always show the query id link (requires log tab to be there currently).

  2. 
      
johan
Review request changed

Status: Closed (submitted)

Loading...