HUE-9001 [editor] Move editor related actions to dropdown button underneath the editor and improve the layout in notebook 2

Review Request #14300 — Created Sept. 17, 2019 and submitted

johan
hue
master
hue
jgauthier, ranade, romain, roohi, weixia, yingc
commit 7a906926d250e6d599e2eb3bdfa51751a32dfb8c
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Tue Sep 17 16:12:53 2019 +0200

    HUE-9001 [editor] Move editor related actions to dropdown button underneath the editor and improve the layout in notebook 2
    
    - Format, explain, clear etc. moved from the left-hand side to a dropdown underneath the editor,
    - The switch between text and file input moved into the settings panel
    - The upper right settings button moved to the dropdown menu below
    - Editor margins reduced
    - Editor is now 100% height

:100644 100644 961bc14c80 63537b0880 M	Gruntfile.js
:000000 100644 0000000000 7b3b4b46b1 A	desktop/core/src/desktop/js/apps/notebook2/components/ko.snippetEditorActions.js
:100644 100644 e715b3f69d dd00818d62 R081	desktop/core/src/desktop/js/apps/notebook2/components/ko.snippetExecuteButtonActions.js	desktop/core/src/desktop/js/apps/notebook2/components/ko.snippetExecuteActions.js
:000000 100644 0000000000 557f371591 A	desktop/core/src/desktop/js/apps/notebook2/components/spec/ko.snippetExecuteActions.spec.js
:100644 100644 04f191761d f31837df21 M	desktop/core/src/desktop/js/apps/notebook2/execution/executor.js
:100644 100644 1d154a779c 8217b809c7 M	desktop/core/src/desktop/js/apps/notebook2/notebook.js
:100644 100644 c9994ca323 320c390f0d M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 93bdbe2e0b 2d8bc6e781 M	desktop/core/src/desktop/js/spec/jasmineSetup.js
:100644 100644 3f59c5aa96 c4715e38f4 M	desktop/core/src/desktop/static/desktop/css/hue.css
:100644 100644 a9f5fe107a 0653a5a5a0 M	desktop/core/src/desktop/static/desktop/css/hue3-extra.css
:000000 100644 0000000000 9d36290403 A	desktop/core/src/desktop/static/desktop/less/components/hue-snippet-editor-actions.less
:100644 100644 0566def173 40c56d9d59 M	desktop/core/src/desktop/static/desktop/less/hue-cross-version.less
:100644 100644 2215498d10 13611dcd8e M	desktop/core/src/desktop/templates/global_js_constants.mako
:000000 100644 0000000000 245c74c3ac A	desktop/libs/notebook/src/notebook/static/notebook/css/notebook2.css
:000000 100644 0000000000 070dfe2b48 A	desktop/libs/notebook/src/notebook/static/notebook/less/notebook2.less
:100644 100644 7f55beb770 f7c8a750a2 M	desktop/libs/notebook/src/notebook/templates/editor.mako
:100644 100644 68d0d2f9a6 01c4acc5da M	desktop/libs/notebook/src/notebook/templates/editor_components.mako
:100644 100644 7e6887e559 d046f53430 M	desktop/libs/notebook/src/notebook/templates/editor_components2.mako
:100644 100644 5331241029 07df0514d4 M	desktop/libs/notebook/src/notebook/templates/notebook.mako

Manual on Chrome + Jasmine

Screenshot%202019-09-17%2016.13.58.png
Screenshot%202019-09-17%2016.14.20.png (fa-fw added to settings icon)
Screenshot%202019-09-17%2016.18.26.png

All behind notebook 2 flag

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
romain
johan
Review request changed

Status: Closed (submitted)

Loading...