HUE-9013 [editor] Switch to event based result handling for the result grid and chart components

Review Request #14343 — Created Oct. 4, 2019 and updated

johan
hue
master
hue
jgauthier, ranade, romain, roohi, weixia, yingc
commit ee9eb1cf8e1367fbeded246e73acd17c99575446
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu Oct 3 17:14:51 2019 +0200

    HUE-9013 [editor] Switch to event based result handling for the result grid and chart components
    
    This also introduces active and latest executable in the snippet to support multiple result handling

:100644 100644 cce4d18c30 a72568e46a M	desktop/core/src/desktop/js/apps/notebook2/components/ko.snippetResults.js
:100644 100644 539b687341 e6bb3e5394 M	desktop/core/src/desktop/js/apps/notebook2/components/resultGrid/ko.resultGrid.js
:100644 100644 0e53abda2e 8cee533b60 M	desktop/core/src/desktop/js/apps/notebook2/execution/executable.js
:100644 100644 1440cd8fdd a23a813bd5 M	desktop/core/src/desktop/js/apps/notebook2/execution/executionResult.js
:100644 100644 45d9f8f1b3 4620731f97 M	desktop/core/src/desktop/js/apps/notebook2/execution/executor.js
:100644 100644 cd157d9db5 320df2f515 M	desktop/core/src/desktop/js/apps/notebook2/execution/sqlExecutable.js
:100644 100644 a1db61be5e f517485462 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 579b6c4e80 cc3555bab2 M	desktop/libs/notebook/src/notebook/templates/editor_components2.mako

commit 8c982b786cda7ed5f606f8c7d10a6698f8d306ef
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu Oct 3 14:36:26 2019 +0200

    HUE-9013 [editor] Improve result layout in notebook 2
    
    This also moves the remaining global layout related functions into the new bindings

:100644 100644 012a0bfafb e0196030e2 M	desktop/core/src/desktop/js/apps/notebook/app.js
:000000 100644 0000000000 7c457e855f A	desktop/core/src/desktop/js/apps/notebook2/app.js
:100644 100644 018457f6cc bfafe3aa71 M	desktop/core/src/desktop/js/apps/notebook2/components/ko.snippetExecuteActions.js
:100644 100644 3494360c43 cce4d18c30 M	desktop/core/src/desktop/js/apps/notebook2/components/ko.snippetResults.js
:100644 100644 42489cc8f5 15d79f9f43 M	desktop/core/src/desktop/js/apps/notebook2/components/resultChart/ko.resultChart.js
:100644 100644 11bc3238c5 539b687341 M	desktop/core/src/desktop/js/apps/notebook2/components/resultGrid/ko.resultGrid.js
:000000 100644 0000000000 d2a01247fc A	desktop/core/src/desktop/js/apps/notebook2/events.js
:100644 100644 00fb86f78b 43dc4ba478 M	desktop/core/src/desktop/js/apps/notebook2/notebookSerde.js
:100644 100644 5026cc4d97 a1db61be5e M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 3d0376ad68 7d88ef53bb M	desktop/core/src/desktop/js/ko/bindings/ko.splitFlexDraggable.js
:100644 100644 3a670401a3 85d5aa4898 M	desktop/core/src/desktop/js/ko/components/DisposableComponent.js
:100644 100644 05adc6a429 55058fb5e6 M	desktop/libs/notebook/src/notebook/static/notebook/css/notebook2.css
:100644 100644 28e946b959 fa1f3ec3a3 M	desktop/libs/notebook/src/notebook/static/notebook/less/notebook2.less
:100644 100644 d277c83ea8 579b6c4e80 M	desktop/libs/notebook/src/notebook/templates/editor_components2.mako

commit 8bc0950e34833ba59e7554ac92c28e8e08ff8a8d
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Tue Oct 1 17:11:34 2019 +0200

    HUE-9013 [editor] Move chart logic into the ko.resultChart component

:100644 100644 fa281b03fc 012a0bfafb M	desktop/core/src/desktop/js/apps/notebook/app.js
:100644 100644 121cbf68f5 3494360c43 M	desktop/core/src/desktop/js/apps/notebook2/components/ko.snippetResults.js
:100644 100644 6a4fd8b584 05d3d97cb1 M	desktop/core/src/desktop/js/apps/notebook2/components/resultChart/chartTransformers.js
:100644 100644 01401d06e7 42489cc8f5 M	desktop/core/src/desktop/js/apps/notebook2/components/resultChart/ko.resultChart.js
:100644 100644 55176e29c8 11bc3238c5 M	desktop/core/src/desktop/js/apps/notebook2/components/resultGrid/ko.resultGrid.js
:100644 100644 3ab203d13d bc850ce23d M	desktop/core/src/desktop/js/apps/notebook2/editorViewModel.js
:100644 100644 8217b809c7 7058072407 M	desktop/core/src/desktop/js/apps/notebook2/notebook.js
:100644 100644 624657c280 00fb86f78b M	desktop/core/src/desktop/js/apps/notebook2/notebookSerde.js
:100644 100644 44df6f96fd 55e529bcad M	desktop/core/src/desktop/js/apps/notebook2/result.js
:100644 100644 e653e3af12 5026cc4d97 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 56eaa5541a bec307973a M	desktop/core/src/desktop/js/ko/bindings/charts/mapchart/ko.mapChart.js
:100644 100644 56a45e81e6 3a670401a3 M	desktop/core/src/desktop/js/ko/components/DisposableComponent.js
:100644 100644 b7b2ff2ad1 d277c83ea8 M	desktop/libs/notebook/src/notebook/templates/editor_components2.mako

commit a37af02c65119df5df426a388db7805102392033
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Tue Oct 1 14:45:40 2019 +0200

    HUE-9013 [editor] Move grid result column list logic into the ko.resultGrid component

:100644 100644 cc1e62eb0c 121cbf68f5 M	desktop/core/src/desktop/js/apps/notebook2/components/ko.snippetResults.js
:100644 100644 39e6044a3d 55176e29c8 M	desktop/core/src/desktop/js/apps/notebook2/components/resultGrid/ko.resultGrid.js
:100644 100644 45a668b29f 44df6f96fd M	desktop/core/src/desktop/js/apps/notebook2/result.js
:100644 100644 70f1e1cb67 e653e3af12 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 a2d14092ae b7b2ff2ad1 M	desktop/libs/notebook/src/notebook/templates/editor_components2.mako

commit ccacd787c05b18988b1d271f36252747130249ba
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Tue Oct 1 13:49:22 2019 +0200

    HUE-9013 [editor] Introduce a snippet result component for notebook 2
    
    This component will manage all the visuals for the result of an execution

:000000 100644 0000000000 cc1e62eb0c A	desktop/core/src/desktop/js/apps/notebook2/components/ko.snippetResults.js
:100644 100644 05a0a1e07d 39e6044a3d M	desktop/core/src/desktop/js/apps/notebook2/components/resultGrid/ko.resultGrid.js
:100644 100644 5e4e531fd3 70f1e1cb67 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 c00a2930fd da158c8cdf M	desktop/core/src/desktop/templates/global_js_constants.mako
:100644 100644 2d3da5e6db 28e946b959 M	desktop/libs/notebook/src/notebook/static/notebook/less/notebook2.less
:100644 100644 7a3d912dc4 a2d14092ae M	desktop/libs/notebook/src/notebook/templates/editor_components2.mako

commit d52e7ff9083a6a411a683fb3031d6f34696cb12d
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Mon Sep 30 17:03:04 2019 +0200

    HUE-9013 [editor] Contain data table generation within the new result grid component
    
    This also adds proper disposal to the result view

:100644 100644 1054f71962 fa281b03fc M	desktop/core/src/desktop/js/apps/notebook/app.js
:100644 100644 e817dd55ff 05a0a1e07d M	desktop/core/src/desktop/js/apps/notebook2/components/resultGrid/ko.resultGrid.js
:100644 100644 b42e984a66 45a668b29f M	desktop/core/src/desktop/js/apps/notebook2/result.js
:100644 100644 13cb2f7138 bb8be57fb2 M	desktop/core/src/desktop/js/spec/globalJsConstants.js
:100644 100644 14241ac2f9 4d221d7dbe M	desktop/core/src/desktop/js/utils/hueUtils.js
:100644 100644 7573b20d2b 18ee0d2933 M	desktop/core/src/desktop/static/desktop/js/jquery.tablescroller.js
:100644 100644 1eced8895b 7a3d912dc4 M	desktop/libs/notebook/src/notebook/templates/editor_components2.mako

commit 620bbfd57b9284cd71b6f074e1dd780f0550447f
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Fri Sep 27 17:02:50 2019 +0200

    HUE-9013 [editor] Improve result lifecycle for the executor in notebook 2

:100644 100644 3ea41ffa17 1b2cfc31d3 M	desktop/core/src/desktop/js/api/apiHelper.js
:100644 100644 5bf875b89c 1440cd8fdd M	desktop/core/src/desktop/js/apps/notebook2/execution/executionResult.js
:100644 100644 b0e29c1f6d b42e984a66 M	desktop/core/src/desktop/js/apps/notebook2/result.js
:100644 100644 7af7b2d449 74620c55da M	desktop/core/src/desktop/js/utils/i18n.js

commit bda87a5468030c85f1e89e78225d66b758caa339
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Fri Sep 27 17:01:44 2019 +0200

    HUE-9013 [editor] Remove snippet references from the resultChart component

:100644 100644 6b3fdf96dd 6a4fd8b584 M	desktop/core/src/desktop/js/apps/notebook2/components/resultChart/chartTransformers.js
:100644 100644 acc04cf703 01401d06e7 M	desktop/core/src/desktop/js/apps/notebook2/components/resultChart/ko.resultChart.js
:100644 100644 2636f4630b e817dd55ff M	desktop/core/src/desktop/js/apps/notebook2/components/resultGrid/ko.resultGrid.js
:100644 100644 1358729bb9 5e4e531fd3 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 6f881cd5f9 14241ac2f9 M	desktop/core/src/desktop/js/utils/hueUtils.js
:100644 100644 0fc1a41c34 1eced8895b M	desktop/libs/notebook/src/notebook/templates/editor_components2.mako

commit e5b6e7c9b1803c06902b686d372a4473fd4ba686
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Fri Sep 27 15:53:58 2019 +0200

    HUE-9013 [editor] Show result settings to the left of the grid and chart in notebook 2

:100644 100644 4dd50e7d53 05adc6a429 M	desktop/libs/notebook/src/notebook/static/notebook/css/notebook2.css
:100644 100644 0e33135c63 2d3da5e6db M	desktop/libs/notebook/src/notebook/static/notebook/less/notebook2.less
:100644 100644 eed241a79f 0fc1a41c34 M	desktop/libs/notebook/src/notebook/templates/editor_components2.mako

commit 0d57ef13ef29731e203e388507656d2468e19dc8
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Fri Sep 27 15:52:52 2019 +0200

    HUE-8768 [editor] Fix snippet JS exception in notebook 2

:100644 100644 ee85184dc6 1358729bb9 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js

commit a52e203df0d3dc1409c499dc0ff984fd63120747
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Fri Sep 27 15:51:49 2019 +0200

    HUE-9013 [editor] Extract grid component for notebook 2

:000000 100644 0000000000 2636f4630b A	desktop/core/src/desktop/js/apps/notebook2/components/resultGrid/ko.resultGrid.js
:100644 100644 5eb5e1f46e ee85184dc6 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 e8e640516e c00a2930fd M	desktop/core/src/desktop/templates/global_js_constants.mako
:100644 100644 840b0444a4 eed241a79f M	desktop/libs/notebook/src/notebook/templates/editor_components2.mako

commit ddc8c5bd430e057799696cfc549fc54c3983ceb1
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Fri Sep 27 15:24:01 2019 +0200

    HUE-9013 [editor] Extract chart component for notebook 2

:000000 100644 0000000000 6b3fdf96dd A	desktop/core/src/desktop/js/apps/notebook2/components/resultChart/chartTransformers.js
:000000 100644 0000000000 acc04cf703 A	desktop/core/src/desktop/js/apps/notebook2/components/resultChart/ko.resultChart.js
:100644 100644 5775ac72f8 5eb5e1f46e M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 e6a63b4486 74982e2c3b M	desktop/core/src/desktop/js/ko/components/assist/ko.assistEditorContextPanel.js
:100644 100644 462337eb2c e8e640516e M	desktop/core/src/desktop/templates/global_js_constants.mako
:100644 100644 74b6822080 840b0444a4 M	desktop/libs/notebook/src/notebook/templates/editor_components2.mako

Manual on Chrome + Jasmine

In-between review of the editor 2 improvements, all behind feature flag ENABLE_NOTEBOOK_2

Grid view
Chart view
Result settings moved from left to on top

Left to do:
- Handle logs
- Add history record
- Save multiple results with notebook
- Iterate on design/layout
- Show active or last executed statement results switch
- Make sure notebook mode works
- Non-SQL snippet excecution and results

Loading...