HUE-9028 [editor] Enable parallel click to execute in notebook 2

Review Request #14356 — Created Oct. 9, 2019 and updated

johan
hue
master
hue
jgauthier, ranade, romain, roohi, weixia, yingc
commit ccd89e37b4246f39d99223b9ba518ea9406e5f80
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Oct 9 17:20:09 2019 +0200

    HUE-9028 [editor] Enable parallel click to execute in notebook 2

:100644 100644 2be953b99e ce107a72f2 M	desktop/core/src/desktop/js/api/apiHelper.js
:100644 100644 f426178c39 28dc3fb2b1 M	desktop/core/src/desktop/js/apps/notebook2/components/ko.executableLogs.js
:100644 100644 fa4e16b34b e36bf1003e M	desktop/core/src/desktop/js/apps/notebook2/components/ko.executableProgressBar.js
:100644 100644 9f86e9a861 c85a353c65 M	desktop/core/src/desktop/js/apps/notebook2/components/ko.snippetExecuteActions.js
:100644 100644 44c275034b a37b6bd5d3 M	desktop/core/src/desktop/js/apps/notebook2/components/ko.snippetResults.js
:100644 100644 0c71cb9390 657fb1e755 M	desktop/core/src/desktop/js/apps/notebook2/components/spec/ko.executableProgressBar.spec.js
:100644 100644 31452cff72 1bcfbb7f7d M	desktop/core/src/desktop/js/apps/notebook2/components/spec/ko.snippetExecuteActions.spec.js
:100644 100644 1100cc9e7e fb6b6f62d4 M	desktop/core/src/desktop/js/apps/notebook2/execution/executable.js
:100644 100644 26058b98e3 8f651794e0 M	desktop/core/src/desktop/js/apps/notebook2/execution/executor.js
:100644 100644 3fd148fd22 62b18dd8a5 M	desktop/core/src/desktop/js/apps/notebook2/execution/spec/sqlExecutableSpec.js
:100644 100644 062d20e646 ab6e13309a M	desktop/core/src/desktop/js/apps/notebook2/execution/sqlExecutable.js
:100644 100644 15b955f121 1fc40423e1 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 c08c0d6bea 048180be42 M	desktop/core/src/desktop/js/sql/aceLocationHandler.js
:100644 100644 2972df167c 026ac12982 M	desktop/libs/notebook/src/notebook/templates/editor_components2.mako

commit bf2998410d0abbcaf7788309e4ecc5cf81b3b9e6
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Oct 9 14:59:36 2019 +0200

    HUE-9028 [editor] Remove old result and execution logic from the snippet in notebook2

:100644 100644 31fd366e7e 9f86e9a861 M	desktop/core/src/desktop/js/apps/notebook2/components/ko.snippetExecuteActions.js
:100644 100644 52be32a82e 0c71cb9390 M	desktop/core/src/desktop/js/apps/notebook2/components/spec/ko.executableProgressBar.spec.js
:100644 100644 e772705218 31452cff72 M	desktop/core/src/desktop/js/apps/notebook2/components/spec/ko.snippetExecuteActions.spec.js
:100644 100644 bc850ce23d 628cff9e32 M	desktop/core/src/desktop/js/apps/notebook2/editorViewModel.js
:100644 100644 99b45289bd 15b955f121 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js

commit 10e3eb7c3bb2e2ed4329f4f45bb5d815f8a4b2e6
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Oct 9 14:52:45 2019 +0200

    HUE-9005 [editor] Extract log handling to a separate log component

:100644 100644 1b2cfc31d3 2be953b99e M	desktop/core/src/desktop/js/api/apiHelper.js
:000000 100644 0000000000 f426178c39 A	desktop/core/src/desktop/js/apps/notebook2/components/ko.executableLogs.js
:100644 100644 250eac2808 44c275034b M	desktop/core/src/desktop/js/apps/notebook2/components/ko.snippetResults.js
:100644 100644 15d79f9f43 caffd23ac9 M	desktop/core/src/desktop/js/apps/notebook2/components/resultChart/ko.resultChart.js
:100644 100644 bc7aac5b60 c21b4cb0d8 M	desktop/core/src/desktop/js/apps/notebook2/components/resultGrid/ko.resultGrid.js
:100644 100644 8cee533b60 1100cc9e7e M	desktop/core/src/desktop/js/apps/notebook2/execution/executable.js
:000000 100644 0000000000 edaa32abf9 A	desktop/core/src/desktop/js/apps/notebook2/execution/executionLogs.js
:100644 100644 a23a813bd5 515b8c23b3 M	desktop/core/src/desktop/js/apps/notebook2/execution/executionResult.js
:100644 100644 320df2f515 062d20e646 M	desktop/core/src/desktop/js/apps/notebook2/execution/sqlExecutable.js
:100644 100644 5986ed0440 99b45289bd M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 cbd54c162d 710e9b3535 M	desktop/core/src/desktop/js/ko/components/DisposableComponent.js
:100644 100644 cc3555bab2 2972df167c M	desktop/libs/notebook/src/notebook/templates/editor_components2.mako

commit c0325a8c45505995d98b56b773c57ceadcc2793a
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Tue Oct 8 13:54:20 2019 +0200

    HUE-9028 [editor] Switch to fixed executor per snippet

:100644 100644 400b1c277e bf4fd63b86 M	desktop/core/src/desktop/js/apps/notebook2/app.js
:100644 100644 83242b6108 fa4e16b34b M	desktop/core/src/desktop/js/apps/notebook2/components/ko.executableProgressBar.js
:100644 100644 bfafe3aa71 31fd366e7e M	desktop/core/src/desktop/js/apps/notebook2/components/ko.snippetExecuteActions.js
:100644 100644 470a54b117 250eac2808 M	desktop/core/src/desktop/js/apps/notebook2/components/ko.snippetResults.js
:100644 100644 4620731f97 26058b98e3 M	desktop/core/src/desktop/js/apps/notebook2/execution/executor.js
:100644 100644 a4e68d3f82 5986ed0440 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
Manual on Chrome
  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
romain
  1. 
      
  2. Should investigate vuejs at some point, to avoid all templating in a string

    1. Yeah, need to do a final clean-up round on the new snippet. I'll also do a compare with the old and new to make sure I didn't miss anything.

  3. 
      
Loading...