HUE-8737 [hive] Fix Hive thrift for Python 3.5

Review Request #14359 — Created Oct. 9, 2019 and updated

yingc
hue
master
HUE-8737
jgauthier, johan, ranade, romain, weixia
commit 3659794587c59b777cfdff544e855e190a92c365 (HEAD -> py3_prep2)
Author: Ying Chen <yingchen@cloudera.com>
Date:   Wed Apr 17 13:36:02 2019 -0700

    HUE-8737 [hive] Fix Hive thrift for Python 3.5

:100644 100644 5034456fe4... 20b3a8abf4... M    apps/beeswax/src/beeswax/api.py
:100644 100644 f81d8c375e... c749f2da31... M    apps/beeswax/src/beeswax/conf.py
:100644 100644 4c72d908c7... c0127b87ee... M    apps/beeswax/src/beeswax/models.py
:100644 100644 842b7a49db... 9fae9c1a82... M    desktop/core/src/desktop/lib/thrift_sasl.py
:100644 100644 bc4448c09d... 9d9cf8ea4f... M    desktop/core/src/desktop/lib/thrift_util.py


  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
romain
  1. 
      
  2. apps/beeswax/src/beeswax/api.py (Diff revision 1)
     
     

    Cf. https://github.com/cloudera/hue/commit/9a92dc12082e5e9b1d9f66cb1846b98992c753e9 this looks wrong for py2. We should be careful there.

    What is the proper way to get the info in Py3?

    1. Seems using str(e) would be safer. Like https://github.com/VingtCinq/python-mailchimp/pull/65, exception is using strings.
    2. +1 on str()

      https://stackoverflow.com/questions/1272138/baseexception-message-deprecated-in-python-2-6
      https://www.python.org/dev/peps/pep-0352/

  3. 
      
yingc
Review request changed
romain
  1. Ship It!
  2. 
      
Loading...