HUE-9028 [editor] Add support for select to execute multiple in notebook 2

Review Request #14365 — Created Oct. 11, 2019 and submitted

johan
hue
master
hue
jgauthier, ranade, romain, roohi, weixia, yingc
commit b0e9b7024965af37c2370734ae8709a5e4ad60ae
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Fri Oct 11 12:02:07 2019 +0200

    HUE-9028 [editor] Add support for select to execute multiple in notebook 2
    
    When selecting multiple statements it will execute all of them in order without stopping as we now store the result per statement. It's also possible to execute multiple chains in parallel by selecting non-intersecting chains.
    
    If a previous selected execution chain is intersecting a new execution it will cancel the previous chain.

:100644 100644 6553ea63bc 9ac0da4116 R094	desktop/core/src/desktop/js/apps/notebook2/components/ko.snippetExecuteActions.js	desktop/core/src/desktop/js/apps/notebook2/components/ko.executableActions.js
:100644 100644 fe78d38bc8 de656374bd M	desktop/core/src/desktop/js/apps/notebook2/components/ko.executableProgressBar.js
:100644 100644 1bcfbb7f7d a5999b2a8f R089	desktop/core/src/desktop/js/apps/notebook2/components/spec/ko.snippetExecuteActions.spec.js	desktop/core/src/desktop/js/apps/notebook2/components/spec/ko.executableActions.spec.js
:100644 100644 e5bae15be2 a3d49042ee M	desktop/core/src/desktop/js/apps/notebook2/execution/executable.js
:100644 100644 8f651794e0 fdb0cebb2f M	desktop/core/src/desktop/js/apps/notebook2/execution/executor.js
:100644 100644 ab6e13309a 9d2ce709b1 M	desktop/core/src/desktop/js/apps/notebook2/execution/sqlExecutable.js
:100644 100644 bcd3fd1a29 f5b17a81b3 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 048180be42 337b2674d1 M	desktop/core/src/desktop/js/sql/aceLocationHandler.js
:100644 100644 e09b8d5a77 a9a7e610de M	desktop/libs/notebook/src/notebook/templates/editor_components2.mako

commit bfcef532eeb6de62bdcccb0ab05b9a604bbab773
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu Oct 10 14:34:47 2019 +0200

    HUE-9004 [editor] Remove execution progress tracking from the snippet in notebook 2

:100644 100644 bf4fd63b86 d7c2ff5648 M	desktop/core/src/desktop/js/apps/notebook2/app.js
:100644 100644 e36bf1003e fe78d38bc8 M	desktop/core/src/desktop/js/apps/notebook2/components/ko.executableProgressBar.js
:100644 100644 33f699d340 47529d80b6 M	desktop/core/src/desktop/js/apps/notebook2/components/ko.snippetEditorActions.js
:100644 100644 b4afa4ea55 bcd3fd1a29 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js

commit 72f195b4717f94dc509b31b8888b9a0722a7c25f
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu Oct 10 13:45:38 2019 +0200

    HUE-9028 [editor] Fix issue with re-execution of a statement in Notebook 2

:100644 100644 ce107a72f2 dfdde7a55e M	desktop/core/src/desktop/js/api/apiHelper.js
:100644 100644 c85a353c65 6553ea63bc M	desktop/core/src/desktop/js/apps/notebook2/components/ko.snippetExecuteActions.js
:100644 100644 fb6b6f62d4 e5bae15be2 M	desktop/core/src/desktop/js/apps/notebook2/execution/executable.js
:100644 100644 edaa32abf9 8c48406e48 M	desktop/core/src/desktop/js/apps/notebook2/execution/executionLogs.js
:100644 100644 1fc40423e1 b4afa4ea55 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 90d5ba9700 9195d1cc48 M	desktop/core/src/desktop/js/parse/jison/sqlStatementsParser.jison
:100644 100644 e73795ff4c b216ef120f M	desktop/core/src/desktop/js/parse/spec/sqlStatementsParserSpec.js
:100644 100644 61ab1ad832 c3a432dd55 M	desktop/core/src/desktop/js/parse/sqlStatementsParser.js
:100644 100644 026ac12982 e09b8d5a77 M	desktop/libs/notebook/src/notebook/templates/editor_components2.mako

Manual on Chrome + Jasmine

https://dl.dropbox.com/s/207253lnvhkpn56/HUE-9028_Multiple.executions.with.selection.mp4?dl=0

Left to do on top of my head:
- Switch to execute/close/status/logs/result APIs that don't care about notebooks
- Add API to persist history record (has to be defined)
- Progress indicator in gutter of what's going on
- Prevent editing of something being executed (or option to stop)
- Button to stop all execution and indication of something being executed in batch
- Save/load of notebook with multiple executables and results
- Notebook on par with non-sql type snippets (probably quite broken at this point)
- Add explain component
- Possibility to pin result tabs?
- Global notification on executable status
- Iterate on UI design and layout buttons etc.
- Move actions for history and saved queries to similar action row below the "tab"

romain
  1. Amazing progress!

  2. 
      
johan
Review request changed

Status: Closed (submitted)

Loading...