HUE-9028 [editor] Add execution errors to the logs component and properly mark them in the gutter

Review Request #14370 — Created Oct. 14, 2019 and submitted

johan
hue
master
hue
jgauthier, ranade, romain, roohi, weixia, yingc
commit 64ee21aad069a80e6c872ad67e343b04389bd2b2
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Mon Oct 14 16:50:53 2019 +0200

    HUE-9028 [editor] Add execution errors to the logs component and properly mark them in the gutter

:100644 100644 28dc3fb2b1 5ab3c2d46c M	desktop/core/src/desktop/js/apps/notebook2/components/ko.executableLogs.js
:100644 100644 3b3360c630 fcdd7a5b6e M	desktop/core/src/desktop/js/apps/notebook2/execution/executable.js
:100644 100644 8c48406e48 58973137a6 M	desktop/core/src/desktop/js/apps/notebook2/execution/executionLogs.js
:100644 100644 9d2ce709b1 23b3ef1803 M	desktop/core/src/desktop/js/apps/notebook2/execution/sqlExecutable.js
:100644 100644 e0275861c6 3e155bff3b M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 f17cfd655e 59d2b22b3b M	desktop/core/src/desktop/js/ko/bindings/ace/aceGutterHandler.js
:100644 100644 44406c0654 5f56545ee9 M	desktop/core/src/desktop/static/desktop/css/hue.css
:100644 100644 c77534920d 70f3799e11 M	desktop/core/src/desktop/static/desktop/css/hue3-extra.css
:100644 100644 dbc8881e2e 73024cbf2e M	desktop/core/src/desktop/static/desktop/less/hue-cross-version.less

commit 499764253a2a00c10234a7dd0130977a0aed62e1
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Mon Oct 14 15:49:46 2019 +0200

    HUE-9028 [editor] Notify on executable refresh while editing

:100644 100644 fdb0cebb2f ec846e4f87 M	desktop/core/src/desktop/js/apps/notebook2/execution/executor.js
:100644 100644 138b9e96ec f17cfd655e M	desktop/core/src/desktop/js/ko/bindings/ace/aceGutterHandler.js

commit ef7679922162e6b6cc97d774840ba8424cbc8843
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Mon Oct 14 12:33:39 2019 +0200

    HUE-9028 [editor] Indicate execution status in the gutter

:100644 100644 e7ae38b70a 3b3360c630 M	desktop/core/src/desktop/js/apps/notebook2/execution/executable.js
:100644 100644 5cc19abff5 e0275861c6 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:000000 100644 0000000000 138b9e96ec A	desktop/core/src/desktop/js/ko/bindings/ace/aceGutterHandler.js
:100644 100644 337b2674d1 83f2c99706 R097	desktop/core/src/desktop/js/sql/aceLocationHandler.js	desktop/core/src/desktop/js/ko/bindings/ace/aceLocationHandler.js
:100644 100644 978dbaeaaf 669af1247d R098	desktop/core/src/desktop/js/ko/bindings/ko.aceEditor.js	desktop/core/src/desktop/js/ko/bindings/ace/ko.aceEditor.js
:100644 100644 57c90d1d82 57c90d1d82 R100	desktop/core/src/desktop/js/ko/bindings/ko.aceResizer.js	desktop/core/src/desktop/js/ko/bindings/ace/ko.aceResizer.js
:100644 100644 9ac847660f d44fe1f4be M	desktop/core/src/desktop/js/ko/components/simpleAceEditor/ko.simpleAceEditor.js
:100644 100644 4054f89a7c 90a5bb8604 M	desktop/core/src/desktop/js/ko/ko.all.js
:100644 100644 d6b9e8153b 44406c0654 M	desktop/core/src/desktop/static/desktop/css/hue.css
:100644 100644 eade8e0544 c77534920d M	desktop/core/src/desktop/static/desktop/css/hue3-extra.css
:100644 100644 40c56d9d59 dbc8881e2e M	desktop/core/src/desktop/static/desktop/less/hue-cross-version.less
:100644 100644 e1576e4abb ac4386965b M	desktop/core/src/desktop/static/desktop/less/hue-mixins.less
Manual on Chrome
romain
  1. BTW: is Ace rebasing possible/worth before we move even further?

    1. It'd be good to do, pull it in with npm instead of embedding the Ace source in Hue. Need to figure out a good approach, probably first diff with the Ace source we originally added and then apply the changes from the outside instead with the new version.

      Another popular one nowadays is https://github.com/microsoft/monaco-editor

  2. 
      
johan
Review request changed

Status: Closed (submitted)

Loading...