HUE-9045 [core] Remove chardet import from requests-2.18.4

Review Request #14395 — Created Oct. 22, 2019 and updated

yingc
hue
master
HUE-9045
jgauthier, johan, ranade, romain, weixia
commit 33efbad5b135c886507b0b06f443156d9aac3193 (HEAD -> master)
Author: Ying Chen <yingchen@cloudera.com>
Date:   Sat Oct 19 09:34:51 2019 -0700

    HUE-9045 [core] Remove chardet import from requests-2.18.4

:100644 100644 268e7dcc53... b6ff0f40c5... M    desktop/core/ext-py/requests-2.18.4/requests/__init__.py
:100644 100644 f417cfd8d0... 39d937f65b... M    desktop/core/ext-py/requests-2.18.4/requests/compat.py
:100644 100644 5440ee614e... a50644ac9d... M    desktop/core/ext-py/requests-2.18.4/requests/help.py
:100644 100644 4041cac3f0... f834427d6b... M    desktop/core/ext-py/requests-2.18.4/requests/models.py
:100644 100644 7232fe0ff7... edff5eb2ac... M    desktop/core/ext-py/requests-2.18.4/requests/packages.py
:100644 100644 a1580355d6... 985e3a723a... M    desktop/core/src/desktop/lib/python_util.py
:100644 100644 8ccf5f2a0e... acccd3694c... M    desktop/libs/indexer/src/indexer/api3.py


  • 0
  • 0
  • 1
  • 1
  • 2
Description From Last Updated
jgauthier
  1. 
      
  2. Could return empty? Throw error?

    1. Try hardcoded return empty string, but requests itself handles error at https://github.com/cloudera/hue/blob/master/desktop/core/ext-py/requests-2.18.4/requests/models.py#L857.
  3. 
      
yingc
romain
  1. Nice!

    Maybe quick try to import a file with chinese data in the importer to see how it goes?

    1. import GB2312 file, it shows unrecogniziable characters

  2. nit: add a comment that this is a simplified alternative to GPL chardet?

  3. 
      
yingc
Review request changed
Loading...