HUE-9066 [core] Getting the skeleton of gist collaboration

Review Request #14446 — Created Nov. 5, 2019 and submitted

romain
hue
master
HUE-9066
hue
jgauthier, johan, ranade, romain, weixia, yingc
commit 2861235d45fc82ce338f25d0f417a1f80ac18a66
Author: Romain <romain.rigaux@gmail.com>
Date:   Mon Oct 28 14:16:35 2019 +0100

    HUE-9066 [gist] Properly load back the SQL gist

:100644 100644 74279488e6 7d790438e6 M	desktop/core/src/desktop/api2.py
:100644 100644 08fb52bbeb 14617ae3ef M	desktop/core/src/desktop/js/api/apiHelper.js
:100644 100644 e9d3a64c16 e16c81a8d8 M	desktop/core/src/desktop/js/apps/notebook/editorViewModel.js
:100644 100644 965eeacfbe b7c25e90d9 M	desktop/core/src/desktop/js/apps/notebook/snippet.js
:100644 100644 44c2d3ee39 0f192e4002 M	desktop/core/src/desktop/js/apps/notebook2/components/ko.snippetEditorActions.js
:100644 100644 7a09cb85de 48d6e63e30 M	desktop/core/src/desktop/models.py
:100644 100644 cb77a86f15 8a05d066ad M	desktop/core/src/desktop/templates/common_header_footer_components.mako
:100644 100644 be9a9e2ccf b480bba265 M	desktop/core/src/desktop/templates/global_js_constants.mako
:100644 100644 4f47c1c65f 5941e379f2 M	desktop/libs/notebook/src/notebook/api.py
:100644 100644 1e5c2d12ec 6fd3c0c859 M	desktop/libs/notebook/src/notebook/templates/editor_components.mako

commit 6bb89f3f2c26012ae0e0accb1003df0bc4d3aef7
Author: Romain <romain.rigaux@gmail.com>
Date:   Mon Oct 28 09:57:25 2019 +0100

    HUE-9066 [gist] Adding link in popup

:100644 100644 3b66a01116 74279488e6 M	desktop/core/src/desktop/api2.py
:100644 100644 028ed885d4 965eeacfbe M	desktop/core/src/desktop/js/apps/notebook/snippet.js
:100644 100644 5d0bdce27b cb77a86f15 M	desktop/core/src/desktop/templates/common_header_footer_components.mako
:100644 100644 8f54a4ebc3 571a5a3aff M	desktop/libs/notebook/src/notebook/views.py

commit c15ca6f8524176287a864ca1b3d5f0ebaa1466f6
Author: Romain <romain.rigaux@gmail.com>
Date:   Sun Oct 27 12:11:46 2019 +0100

    HUE-9066 [notebook] Load gist id as new editor with default values

:100644 100644 7d864e261c 3b66a01116 M	desktop/core/src/desktop/api2.py
:100644 100644 6e26882f10 08fb52bbeb M	desktop/core/src/desktop/js/api/apiHelper.js
:100644 100644 f719bbe780 e9d3a64c16 M	desktop/core/src/desktop/js/apps/notebook/editorViewModel.js
:100644 100644 a3d3a752b4 bd79e2c513 M	desktop/core/src/desktop/js/onePageViewModel.js
:100644 100644 adbd368aed 7a09cb85de M	desktop/core/src/desktop/models.py
:100644 100644 0daa0c400d 5c5dc393e9 M	desktop/core/src/desktop/urls.py
:100644 100644 37a345aca7 4f47c1c65f M	desktop/libs/notebook/src/notebook/api.py
:100644 100644 4708cdbfae fc85870e4d M	desktop/libs/notebook/src/notebook/decorators.py
:100644 100644 e19ce48819 8f54a4ebc3 M	desktop/libs/notebook/src/notebook/views.py

commit 1aa96af72159aad4c681a1f5977e6b09a9dea01f
Author: Romain <romain.rigaux@gmail.com>
Date:   Sun Oct 27 10:28:50 2019 +0100

    HUE-9066 [desktop] Move __paginate util to the model instead of api module

:100644 100644 44e2708cd1 7d864e261c M	desktop/core/src/desktop/api2.py
:100644 100644 323731eaed adbd368aed M	desktop/core/src/desktop/models.py
:100644 100644 50059b7b5d 37a345aca7 M	desktop/libs/notebook/src/notebook/api.py

commit 3a4025cac19769fbfb36db4dee2d0540e640da56
Author: Romain <romain.rigaux@gmail.com>
Date:   Sun Oct 27 10:26:51 2019 +0100

    HUE-9066 [notebook] Open gist in editor

:100644 100644 143d99c504 44e2708cd1 M	desktop/core/src/desktop/api2.py
:100644 100644 e311152a83 50059b7b5d M	desktop/libs/notebook/src/notebook/api.py
:100644 100644 d2b2862188 e19ce48819 M	desktop/libs/notebook/src/notebook/views.py

commit 6d10edf18ecd0ee9e88ccf6859f6990238784da9
Author: Romain <romain.rigaux@gmail.com>
Date:   Sun Oct 27 08:26:18 2019 +0100

    HUE-9066 [gist] Create a get method

:100644 100644 4c15ef5ed2 143d99c504 M	desktop/core/src/desktop/api2.py

commit fd0e89d059c8a3b25d757744de50f58d65cb37f6
Author: Romain <romain.rigaux@gmail.com>
Date:   Sun Oct 27 08:09:18 2019 +0100

    HUE-9066 [gist] Adding create API

:100644 100644 47820d4915 4c15ef5ed2 M	desktop/core/src/desktop/api2.py
:100644 100644 dfdde7a55e 6e26882f10 M	desktop/core/src/desktop/js/api/apiHelper.js
:100644 100644 5e9b90d553 028ed885d4 M	desktop/core/src/desktop/js/apps/notebook/snippet.js
:100644 100644 03c5530cc0 0daa0c400d M	desktop/core/src/desktop/urls.py
:100644 100644 11ca62f618 1e5c2d12ec M	desktop/libs/notebook/src/notebook/templates/editor_components.mako

commit 055d866b1c28d8f8861779311e5952d29c919099
Author: Romain <romain.rigaux@gmail.com>
Date:   Mon Oct 21 18:37:54 2019 +0300

    HUE-9066 [gist] Adding link button in sub execute dropdown

:100644 100644 47529d80b6 44c2d3ee39 M	desktop/core/src/desktop/js/apps/notebook2/components/ko.snippetEditorActions.js
:100644 100644 e1d2fd093b be9a9e2ccf M	desktop/core/src/desktop/templates/global_js_constants.mako
:100644 100644 6a33c7d24d 11ca62f618 M	desktop/libs/notebook/src/notebook/templates/editor_components.mako

Skeleton of core. Porting to Editor 2, more UX and a few bugs to polish.

  • 1
  • 0
  • 0
  • 0
  • 1
Description From Last Updated
Looking at this it looks very similar to regular documents. Would it make sense to just add the ability to ... jgauthier jgauthier
jgauthier
  1. 
      
  2. Looking at this it looks very similar to regular documents. Would it make sense to just add the ability to make a document public (like google doc) instead instead of creating a new type?

    1. We need this one at some point too but this is not as lightweight as a gist which is literraly just a copy paste of a fragment of a query. e.g. https://gist.github.com/

  3. 
      
romain
Review request changed

Status: Closed (submitted)

Loading...