HUE-8900 [editor] Fix loading queries with 0 results

Review Request #14451 — Created Nov. 6, 2019 and submitted

johan
hue
master
hue
jgauthier, ranade, romain, roohi, weixia, yingc
commit bcb9d145ccab6b2446a581fed1478f347fa366cc
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Nov 6 13:47:09 2019 +0100

    HUE-8900 [editor] Fix loading queries with 0 results

:100644 100644 5ab3c2d46c c5c79eeea8 M	desktop/core/src/desktop/js/apps/notebook2/components/ko.executableLogs.js
:100644 100644 d2d7831da7 bbcbce823f M	desktop/core/src/desktop/js/apps/notebook2/components/resultChart/ko.resultChart.js

commit c6d3f1530370cc6a05780f3edea273e95d3cf67f
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Nov 6 13:47:02 2019 +0100

    HUE-8900 [editor] Remove dead code in notebook 2

:100644 100644 e61bc70e5c 3cb5004b2f M	desktop/core/src/desktop/js/apps/notebook2/components/resultGrid/ko.resultGrid.js
:100644 000000 55e529bcad 0000000000 D	desktop/core/src/desktop/js/apps/notebook2/result.js

commit 6cb7156ba347a5d1d504f0077a9d401d7196bce4
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Nov 6 13:35:45 2019 +0100

    HUE-8900 [editor] Fix issue with undefined chart settings when switching between results

:100644 100644 451fea477a d2d7831da7 M	desktop/core/src/desktop/js/apps/notebook2/components/resultChart/ko.resultChart.js
:100644 100644 97a5135350 c27c480a6f M	desktop/core/src/desktop/js/apps/notebook2/execution/executable.js
Manual on Chrome
  • 0
  • 0
  • 0
  • 2
  • 2
Description From Last Updated
romain
  1. 
      
  2. And still fine when clicking on the 'Explain' button?

    1. Explain isn't part of "result" anymore, SoC. So they don't affect eachother like before.

  3. Similarly, do you think we are leaking the result Clipboard copy too?

    https://github.com/cloudera/hue/blob/master/desktop/core/src/desktop/templates/common_notebook_ko_components.mako#L392

    1. I need to fix the clipboard still in notebook 2...

  4. 
      
johan
Review request changed

Status: Closed (submitted)

Loading...