HUE-8737 [editor] Remove _unpack_guid_secret_in_handle in py3

Review Request #14460 — Created Nov. 7, 2019 and updated

yingc
hue
master
HUE-8737
jgauthier, johan, ranade, romain, weixia
commit 53b9ca33bcca12f177e819fc9c1ea0c1a6e295ff (HEAD -> master)
Author: Ying Chen <yingchen@cloudera.com>
Date:   Thu Nov 7 11:00:14 2019 -0800

    HUE-8737 [editor] Fix _unpack_guid_secret_in_handle in py3

:100644 100644 1d49f777f6... 520503f517... M    desktop/core/src/desktop/lib/thrift_util.py
:100644 100644 cc74e93474... fbb8856d34... M    desktop/core/src/desktop/lib/thrift_util_test.py
:100644 100644 148943d058... 5885e2c682... M    desktop/libs/notebook/src/notebook/connectors/hiveserver2.py


  • 0
  • 0
  • 3
  • 0
  • 3
Description From Last Updated
jgauthier
  1. Ship It!
  2. 
      
romain
  1. 
      
  2. Is there a way to no modify this file?
    It is autogenerated so it will break at some point.

  3. 
      
yingc
romain
  1. 
      
  2. Do we really need the extra \ quotes as the string is defined with the opposite ones?
    
    e.g.
    
    'guid=(b\".*\"), secret'
    
    -->
    
    'guid=(b".*"), secret'
  3. Do we really need the case with multiple right parentheses?
    
    e.g.
    
    re.search('secret=(b\".*\")\)\)', str_args) or 
    re.search('secret=(b\".*\")\),', str_args) or 
    
    --> (non greedy)
    
    re.search('secret=(b\".+?\")\)', str_args)
  4. 
      
yingc
Review request changed
romain
  1. Ship It!
  2. 
      
Loading...