HUE-9075 [solr] Fix Solr query return 414 response code when GET parameters is too long

Review Request #14465 — Created Nov. 8, 2019 and submitted Nov. 14, 2019, 5:16 p.m.

Information
Owner:	yingc
Repository:	hue
Branch:	solr_414_fix
Bugs:	HUE-9075
Depends On:
Reviewers
Groups:
People:	jgauthier, johan, ranade, romain, weixia

Description

commit b4f6ae3999740f67b1a3f5f43b0feea03270cd7c (HEAD -> solr_414_fix)
Author: Ying Chen <yingchen@cloudera.com>
Date:   Fri Nov 8 14:09:32 2019 -0800

    HUE-9075 [solr] Fix Solr query return 414 response code when GET parameters is too long

:100644 100644 2cff2b2476... 232d3417ae... M    desktop/libs/libsolr/src/libsolr/api.py

Testing Done

Issues

0
0
5
0
All Issues: 5

Description	From	Last Updated
Remove and move to line 289s below?	romain	Nov. 12, 2019, 10 a.m.
nit: Facet data can be large, so using POST to avoid HTTP 414	romain	Nov. 12, 2019, 10 a.m.
nit: indent response = self._root.post( '%(collection)s/select' % solr_query, params, data=json_data, contenttype='application/json' )	romain	Nov. 12, 2019, 10 a.m.
nit: new line before 'params'	romain	Nov. 12, 2019, 5:36 p.m.
data=json.dumps({'facet': json_facets}) ?	romain	Nov. 12, 2019, 5:36 p.m.

Some feedback that in general would help reviewing:
- we should provide more context on why we should switch to POST
- we should not leave old commented code

desktop/libs/libsolr/src/libsolr/api.py (Diff revision 1)
Show all issues
```
Remove and move to line 289s below?
```
desktop/libs/libsolr/src/libsolr/api.py (Diff revision 1)
Show all issues
```
nit:
Facet data can be large, so using POST to avoid HTTP 414
```

desktop/libs/libsolr/src/libsolr/api.py (Diff revision 1)

Show all issues

nit: indent
response = self._root.post(

    '%(collection)s/select' % solr_query, params,

    data=json_data,

    contenttype='application/json'

)

Summary:

-	HUE-9075 [solr] Fix Solr query return 414 response code
+	HUE-9075 [solr] Fix Solr query return 414 response code when GET parameters is too long

Description:

~		commit 3225515ab27484935a3db5ad96626c9974e8055b (HEAD -> solr_414_fix)
	~	commit b4f6ae3999740f67b1a3f5f43b0feea03270cd7c (HEAD -> solr_414_fix)
		Author: Ying Chen yingchen@cloudera.com
		Date: Fri Nov 8 14:09:32 2019 -0800

~		HUE-9075 [solr] Fix Solr query return 414 response code
	~	HUE-9075 [solr] Fix Solr query return 414 response code when GET parameters is too long

~		:100644 100644 2cff2b2476... 58873bf686... M desktop/libs/libsolr/src/libsolr/api.py
	~	:100644 100644 2cff2b2476... 232d3417ae... M desktop/libs/libsolr/src/libsolr/api.py