HUE-8737 [core] Fix admin check_config, dump_config and user_list

Review Request #14522 — Created Nov. 19, 2019 and updated

yingc
hue
master
HUE-8737
jgauthier, johan, ranade, romain, weixia
commit a8a87fd13377604ec46e0cf9e6e88e14cdc0da70 (HEAD -> master)
Author: Ying Chen <yingchen@cloudera.com>
Date:   Sat Nov 23 13:47:24 2019 -0800

    Revert "HUE-8905 [core] Apply HUE-8772 to Django-1.11.22 for fixing 'user is missing in mako context'"
    
    This reverts commit cf717de5cd857701535c754cb242a97f08bd9214.

:100644 100644 8d715f8b49... 7f0826c644... M    desktop/core/ext-py/Django-1.11.22/django/template/context.py

commit 6593b4faa016db86e074dadf3994f738995dbfd9
Author: Ying Chen <yingchen@cloudera.com>
Date:   Sat Nov 23 13:45:43 2019 -0800

    HUE-8737 [core] Add monkey patch django_template_context.RequestContext.__init__

:100644 100644 ab1476b01b... 250a906342... M    desktop/core/src/desktop/lib/django_util.py
:100644 100644 4c85ae38ca... 3a410afc2a... M    desktop/core/src/desktop/monkey_patches.py

commit de991a99c7d6ba66183a3f2107b387f918e08e1c
Author: Ying Chen <yingchen@cloudera.com>
Date:   Tue Nov 19 17:38:24 2019 -0800

    HUE-8737 [core] Fix admin check_config, dump_config and user_list

:100644 100644 89eced4a6b... 7ed8fcb2db... M    apps/about/src/about/templates/admin_wizard.mako
:100644 100644 93b4ad61be... 0c01da05df... M    apps/hbase/src/hbase/hbase_site.py
:100644 100644 6ee723b06d... 21d7e76b63... M    desktop/core/src/desktop/lib/config_spec_dump.py
:100644 100644 8dd682b21b... 3cdbbdfc97... M    desktop/core/src/desktop/templates/dump_config.mako
:100644 100644 ae8e851a9a... 3cff5cec40... M    desktop/core/src/desktop/views.py


  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
romain
  1. Nice!

    On main comment about maybe making the monkey patching less hidden.

  2. Should we revert https://github.com/cloudera/hue/commit/cf717de5cd857701535c754cb242a97f08bd9214 and just do it here now in both py2/py3?

    And add a note about it?

    Would it also make sense to move it to https://github.com/cloudera/hue/blob/master/desktop/core/src/desktop/monkey_patches.py ?

    1. Move it in HUE-8737 [core] Add monkey patch django_template_context.RequestContext.__init__
      There was cyclic import problem between django_util.py and monkey_patch.py, and resolved by move them into monkey_patch_username_validator, which seems only got called once
  3. 
      
yingc
Review request changed

Description:

~  

commit 0ddcb5d7239a08d2b5bad04bdf2b5b96af013937 (HEAD -> master)

  ~

commit a8a87fd13377604ec46e0cf9e6e88e14cdc0da70 (HEAD -> master)

  + Author: Ying Chen yingchen@cloudera.com
  + Date: Sat Nov 23 13:47:24 2019 -0800

  +
  +
Revert "HUE-8905 [core] Apply HUE-8772 to Django-1.11.22 for fixing 'user is missing in mako context'"
  +
  +
This reverts commit cf717de5cd857701535c754cb242a97f08bd9214.
  +
  +

:100644 100644 8d715f8b49... 7f0826c644... M desktop/core/ext-py/Django-1.11.22/django/template/context.py

  +
  +

commit 6593b4faa016db86e074dadf3994f738995dbfd9

  + Author: Ying Chen yingchen@cloudera.com
  + Date: Sat Nov 23 13:45:43 2019 -0800

  +
  +
HUE-8737 [core] Add monkey patch django_template_context.RequestContext.__init__
  +
  +

:100644 100644 ab1476b01b... 250a906342... M desktop/core/src/desktop/lib/django_util.py

  + :100644 100644 4c85ae38ca... 3a410afc2a... M desktop/core/src/desktop/monkey_patches.py

  +
  +

commit de991a99c7d6ba66183a3f2107b387f918e08e1c

    Author: Ying Chen yingchen@cloudera.com
    Date: Tue Nov 19 17:38:24 2019 -0800

   
~  
HUE-8737 [core] Fix admin check_config, dump_config and user_list
  ~
HUE-8737 [core] Fix admin check_config, dump_config and user_list
-  
 * monkey patching HUE-8905 for mako context
   
   

:100644 100644 89eced4a6b... 7ed8fcb2db... M apps/about/src/about/templates/admin_wizard.mako

    :100644 100644 93b4ad61be... 0c01da05df... M apps/hbase/src/hbase/hbase_site.py
    :100644 100644 6ee723b06d... 21d7e76b63... M desktop/core/src/desktop/lib/config_spec_dump.py
-   :100644 100644 ab1476b01b... 2aa8b4c3c9... M desktop/core/src/desktop/lib/django_util.py
    :100644 100644 8dd682b21b... 3cdbbdfc97... M desktop/core/src/desktop/templates/dump_config.mako
    :100644 100644 ae8e851a9a... 3cff5cec40... M desktop/core/src/desktop/views.py

Diff:

Revision 2 (+61 -38)

Show changes

romain
  1. Ship It!
  2. 
      
Loading...