HUE-9087 [solr] Move facet.properties.facets_form.aggregate.facetFieldsNames to server side

Review Request #14524 — Created Nov. 20, 2019 and updated

yingc
hue
solr_414_fix
HUE-9087
jgauthier, johan, ranade, romain, weixia
commit 182b514e6ee261152e684b3d1c1788807a60092d (HEAD -> solr_414_fix)
Author: Ying Chen <yingchen@cloudera.com>
Date:   Sun Nov 17 22:24:40 2019 -0800

    HUE-9087 [solr] Move facet.properties.facets_form.aggregate.facetFieldsNames to server side

:100644 100644 95dde99f33... 7fef3a3159... M    desktop/libs/dashboard/src/dashboard/api.py
:100644 100644 21ce298fa2... 7629b1b668... M    desktop/libs/dashboard/src/dashboard/static/dashboard/js/search.ko.js


  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
romain
  1. Could we split each optimization in individual commits? (easier to understand each of them)

    1. Split this with https://review.cloudera.org/r/14500/
  2. Python case is with underscores

  3. 
      
yingc
Review request changed

Summary:

-HUE-9087 [solr] Optimize post request from browser to Hue server
+HUE-9087 [solr] Move facet.properties.facets_form.aggregate.facetFieldsNames to server side

Description:

~  

commit 2bd1627d37150a46643debb2ef753dafa58a5f51 (HEAD -> optimize_post_body)

  ~

commit 182b514e6ee261152e684b3d1c1788807a60092d (HEAD -> solr_414_fix)

    Author: Ying Chen yingchen@cloudera.com
    Date: Sun Nov 17 22:24:40 2019 -0800

   
~  
HUE-9087 [solr] Optimize post request from browser to Hue server
  ~
HUE-9087 [solr] Move facet.properties.facets_form.aggregate.facetFieldsNames to server side
-  
* move facet.properties.facets_form.aggregate.facetFieldsNames to server side
   
~  

:100644 100644 95dde99f33... bfb98de45e... M desktop/libs/dashboard/src/dashboard/api.py

~   :100644 100644 8c3d2fa153... 7629b1b668... M desktop/libs/dashboard/src/dashboard/static/dashboard/js/search.ko.js

  ~

:100644 100644 95dde99f33... 7fef3a3159... M desktop/libs/dashboard/src/dashboard/api.py

  ~ :100644 100644 21ce298fa2... 7629b1b668... M desktop/libs/dashboard/src/dashboard/static/dashboard/js/search.ko.js

Branch:

-master
+solr_414_fix

Diff:

Revision 2 (+21 -5)

Show changes

romain
  1. This one I would wait a bit, this kind of feel more and more complicated

  2. 
      
Loading...