HUE-9100 [editor] Delay execute until session create is completed

Review Request #14618 — Created Dec. 12, 2019 and submitted — Latest diff uploaded

jgauthier
hue
master
hue
jgauthier, johan, ranade, romain, weixia, yingc

commit ed733a8b428b1562d289f3af922fc1fae7d4b2d4
Author: Jean-Francois Desjeans Gauthier <jf.desjeans.gauthier@gmail.com>
Date: Wed Dec 11 13:52:17 2019 -0800

HUE-9100 \[editor\] Delay execute until session create is completed

https://github.com/cloudera/hue/commit/f29efd07cb5ddd4571bfc9bec0e5bf7ecc518d22, https://review.cloudera.org/r/5715/ had introduced a delay in createSession in order to have syntax appear highlighting faster. Many changes have happen since and it's no longer an issue. Snippet.init() potentially calls execute if a statement is available and we wait until createSession is completed, before calling init(). This change is not needed in notebook 2, because execution requires a session. In notebook 1, execution is not dependent on getting a session first.

:100644 100644 cbf0f6e704... 16792078c9... M desktop/core/src/desktop/js/apps/notebook/snippet.js



Loading...