HUE-9100 [editor] Reuse session when opening notebook

Review Request #14620 — Created Dec. 12, 2019 and submitted

jgauthier
hue
master
hue
jgauthier, johan, ranade, romain, weixia, yingc
commit 72812a0bc69160d8aa20563b6176dd61cc1fc7a9
Author: Jean-Francois Desjeans Gauthier <jf.desjeans.gauthier@gmail.com>
Date:   Thu Dec 12 13:47:48 2019 -0800

    HUE-9100 [editor] Reuse session when opening notebook.

:100644 100644 7e7aa665e5... d3822e3c84... M	apps/filebrowser/src/filebrowser/templates/listdir_components.mako
:100644 100644 7560751710... 82ef5f67af... M	apps/metastore/src/metastore/templates/metastore.mako
:100644 100644 2fd21a2ec3... ef2a911abe... M	apps/metastore/src/metastore/templates/popups/load_data.mako
:100644 100644 04d09f0972... 755228ee6e... M	desktop/core/src/desktop/js/apps/notebook/editorViewModel.js
:100644 100644 2ec5d339db... 6bb6da6db8... M	desktop/core/src/desktop/js/apps/table_browser/metastoreTable.js
:100644 100644 618349008b... 6b0c1065ee... M	desktop/core/src/desktop/js/hue.js
:100644 100644 d59093fd92... c1f0092a03... M	desktop/core/src/desktop/js/ko/components/ko.executionAnalysis.js
:100644 100644 c6965bbabb... fae9fae2be... M	desktop/core/src/desktop/js/ko/components/ko.historyPanel.js
:100644 100644 95650f2c53... 32a980702f... M	desktop/core/src/desktop/js/onePageViewModel.js
:100644 100644 ebe3fdef51... a8cb777812... M	desktop/core/src/desktop/templates/common_notebook_ko_components.mako
:100644 100644 65b0785510... a1a512fe18... M	desktop/libs/indexer/src/indexer/templates/importer.mako
:100644 100644 7757ff4051... 459974ebbe... M	desktop/libs/notebook/src/notebook/connectors/hiveserver2.py


  • 0
  • 0
  • 4
  • 0
  • 4
Description From Last Updated
romain
  1. 
      
  2. Is 'resp' defined?

    IIRC here this is Oozie task only so far (not SQL), so not needed

  3. Could this be moved into

    huePubSub.publish('notebook.task.submitted', data);

    to avoid all the duplications?

  4. 
      
jgauthier
jgauthier
romain
  1. 
      
  2. nit: don't we use 'null' instead of 'undefined' typically?

  3. 
      
jgauthier
Review request changed

Status: Closed (submitted)

Loading...