Fish Trophy

jgauthier got a fish trophy!

HUE-9108 [core] Revert prettify unifying the general log level

Review Request #14641 — Created Dec. 18, 2019 and submitted

jgauthier
hue
master
HUE-9108
hue
jgauthier, johan, ranade, romain, weixia, yingc
commit b550bbaa690a381c7980d7e75dd9f81ae132914e
Author: Jean-Francois Desjeans Gauthier <jf.desjeans.gauthier@gmail.com>
Date:   Wed Dec 18 17:03:48 2019 -0800

    HUE-9108 [core] Revert prettify unifying the general log level
    
    This change in
    https://github.com/cloudera/hue/commit/aac6fcbeb7a49682f48ffd9829a05cf0b18e4d93
    The logic does not work, because it compares a logger with a handler
    which does not have the same id.

:100644 100644 da67d467a7... ec39eb24ce... M	desktop/core/src/desktop/log/__init__.py


  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
romain
  1. Few nits about more potentially more Pythonic.

    No way to add a test btw?

  2. Curious, would

    isinstance(h, (FileHandler, RotatingFileHandler))

    be wrong?

    or
    h.class in (FileHandler, RotatingFileHandler)

  3. nit?

    os.path.basename( h.baseFilename)

  4. 
      
jgauthier
Review request changed

Status: Closed (submitted)

Loading...