HUE-9084 [calcite] Adding support for SELECT STREAM

Review Request #14704 — Created Jan. 9, 2020 and submitted

romain
hue
master
HUE-9084
hue
johan, ranade, romain, weixia, yingc
commit 0c9b336116037a8fe679be0a3eb4ca5a3d955c4e
Author: Romain <romain.rigaux@gmail.com>
Date:   Thu Jan 9 14:30:07 2020 +0200

    HUE-9084 [calcite] Update generated parser

:100644 100644 18fc17f88f 6fb942f148 M	desktop/core/src/desktop/js/parse/sql/calcite/calciteAutocompleteParser.js
:100644 100644 214d49b4ae ad7f9c422f M	desktop/core/src/desktop/js/parse/sql/calcite/calciteSyntaxParser.js

commit ff5b432984ed68c2ef16c9f0e6bc05b623fe3482
Author: Romain <romain.rigaux@gmail.com>
Date:   Tue Jan 7 18:25:31 2020 +0100

    HUE-9084 [calcite] Adding support for SELECT STREAM

:100644 100644 3aaf9f9d0c ab1505adf2 M	desktop/core/src/desktop/js/parse/jison/sql/calcite/sql_main.jison
:000000 100644 0000000000 0d14520df3 A	desktop/core/src/desktop/js/parse/jison/sql/calcite/sql_select_stream.jison
:000000 100644 0000000000 131ae6d56c A	desktop/core/src/desktop/js/parse/sql/calcite/test/calciteAutocompleteParser.Select.stream.test.js

commit b394c0e0e33de08c2c2d410b41072834bee13b6a
Author: Romain <romain.rigaux@gmail.com>
Date:   Tue Oct 22 06:04:37 2019 +0300

    HUE-9084 [calcite] Adding STREAM keyword to the lexer

:100644 100644 83dbe72ae5 1f17aee282 M	desktop/core/src/desktop/js/parse/jison/sql/calcite/sql.jisonlex

jest calciteAutocompleteParser.Select.stream.test.js --testPathIgnorePatterns=[]
jest calciteAutocompleteParser --testPathIgnorePatterns=[]

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
johan
  1. Nice one!

  2. $3 is undefined if not present, surround with

    if (!$3) {
    ...
    }

    Or it'll suggest 'distinct' after 'distinct'...

    1. Indeed, adding a test.

      Note: maybe

      doesNotContainKeywords: ['STREAM'],

      should not fail when the parserKeywords is undefined. Updating review, not sure if 'containsKeywords: undefined,', it works but not seen anywhere.

    2. Will fix for undefined

  3. 
      
romain
romain
Review request changed

Status: Closed (submitted)

Loading...