HUE-8737 [beeswax] Fix unit test test_column_format_values_nulls

Review Request #14718 — Created Jan. 21, 2020 and updated

yingc
hue
py3_unittest
HUE-8737
johan, ranade, romain, weixia
commit 3bb89e9a3f0c777485d0b1c87dec8ee20f068eff (HEAD -> py3_unittest)
Author: Ying Chen <yingchen@cloudera.com>
Date:   Tue Jan 21 17:42:53 2020 -0800

     HUE-8737 [beeswax] Fix unit test test_column_format_values_nulls

:100644 100644 06dbfdfb87... b078245a58... M    apps/beeswax/src/beeswax/server/hive_server2_lib.py
:100644 100644 726458d8f7... 5fc8031cd6... M    apps/beeswax/src/beeswax/tests.py
:100644 100644 ece0dad70f... 9eb7c20054... M    desktop/core/src/desktop/lib/python_util.py
ci test in ying-test6 and py3-ci
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
ranade
  1. Ship It!
  2. 
      
romain
  1. Nice! Should we add more test cases or we are confident?

  2. Move outside to a util function?

  3. 
      
yingc
romain
  1. 
      
  2. desktop/core/src/desktop/lib/python_util.py (Diff revision 2)
     
     
     
     
     
     
     
     

    And now easy to add a test?

  3. 
      
yingc
Review request changed

Change Summary:

adding unit tests for from_string_to_bits and get_bytes_from_bits

Description:

~  

commit 6e8ff9f0f0109b99c64e074d6f207d6d2955084e (HEAD -> py3_unittest)

  ~

commit 3bb89e9a3f0c777485d0b1c87dec8ee20f068eff (HEAD -> py3_unittest)

    Author: Ying Chen yingchen@cloudera.com
    Date: Tue Jan 21 17:42:53 2020 -0800

   
   
 HUE-8737 [beeswax] Fix unit test test_column_format_values_nulls
   
~  

:100644 100644 06dbfdfb87... 3225874a34... M apps/beeswax/src/beeswax/server/hive_server2_lib.py

  ~

:100644 100644 06dbfdfb87... b078245a58... M apps/beeswax/src/beeswax/server/hive_server2_lib.py

  + :100644 100644 726458d8f7... 5fc8031cd6... M apps/beeswax/src/beeswax/tests.py
  + :100644 100644 ece0dad70f... 9eb7c20054... M desktop/core/src/desktop/lib/python_util.py

Diff:

Revision 3 (+52 -2)

Show changes

romain
  1. Nice!

  2. 
      
Loading...