HUE-9125 [about] Create a component for the configuration page with filter

Review Request #14721 — Created Jan. 24, 2020 and submitted

johan
hue
master
hue
jgauthier, ranade, romain, roohi, weixia, yingc
commit b4934067bf1fcf3f9b93802008188e6a869c04c4
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Fri Jan 24 10:32:53 2020 -0800

    HUE-9125 [about] Create a component for the configuration page with filter

:100644 100644 4e7a39bf5a 3fba61d65f M	desktop/core/src/desktop/js/api/apiHelper.js
:000000 100644 0000000000 dc58fc554b A	desktop/core/src/desktop/js/apps/about/components/ko.hueConfigTree.js
:100644 100644 8380bd982c 7a6cc43cc9 M	desktop/core/src/desktop/js/ko/ko.all.js
:100644 100644 8774ff42c4 6c5b11cbd3 M	desktop/core/src/desktop/templates/dump_config.mako
:100644 100644 e4081e311a efa457df66 M	desktop/core/src/desktop/views.py

commit 60f48193671965ab10c9552b463d024e45d0279c
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu Jan 23 09:42:00 2020 -0800

    HUE-9125 [api] Add API endpoint for fetching the hue config in json

:100644 100644 d4a4fcf9f8 f49a2028de M	desktop/core/src/desktop/api2.py
:100644 100644 42e05c8ed8 6091d13a1b M	desktop/core/src/desktop/api2_tests.py
:100644 100644 c533046977 cb483e9b75 M	desktop/core/src/desktop/tests.py
:100644 100644 4960bdf022 5ee42e4cd9 M	desktop/core/src/desktop/urls.py

Manual on Chrome

Overall a 1-to-1 match with previous config page, still some flakiness with the app links in the bottom. Moved mako gen to API based and added filter on top.

romain
  1. Nice one!

    Tests should pass or need to point to the API now. No need to worry aout bottom links indeed.

    1. Nit: pull right the input box?

  2. 
      
johan
johan
Review request changed

Status: Closed (submitted)

Loading...