HUE-9138 [core] Show stack trace in popup only in debug mode

Review Request #14738 — Created Feb. 3, 2020 and updated

yingc
hue
master
HUE-9138
johan, ranade, romain, weixia
commit ff231c5f8be3848072134ee426aa54c799cf282e (HEAD -> master)
Author: Ying Chen <yingchen@cloudera.com>
Date:   Mon Feb 3 13:57:12 2020 -0800

    HUE-9138 [core] Show stack trace in popup only in debug mode

:100644 100644 90117c2ae8... 114045e067... M    desktop/core/src/desktop/lib/exceptions_renderable.py


  • 2
  • 0
  • 0
  • 0
  • 2
Description From Last Updated
" and DJANGO_DEBUG_MODE.get()" Really needed? If 'data['traceback']' is None because of the DEBUG_MODE flag above it should be automatically false romain romain
reset = DJANGO_DEBUG_MODE.set_for_testing(true) assert_false(resp.context[0]['traceback']) # assert_false(resp.context['traceback']) reset() romain romain
romain
  1. 
      
  2. " and DJANGO_DEBUG_MODE.get()" Really needed?

    If 'data['traceback']' is None because of the DEBUG_MODE flag above it should be automatically false

    1. PS: should be unit testable with DJANGO_DEBUG_MODE.set_for_testing(true) and checking that the traceback value is None

  3. 
      
romain
  1. 
      
  2. reset = DJANGO_DEBUG_MODE.set_for_testing(true)
    assert_false(resp.context[0]['traceback'])
    
    # assert_false(resp.context['traceback'])
    
    reset()
  3. 
      
Loading...