HUE-9180 [useradmin] Convert LDAP names to unicode to reduce length

Review Request #14813 — Created Feb. 27, 2020 and submitted

yingc
hue
hdfs_plus_sign
HUE-9180
johan, ranade, romain, weixia
commit 27fcd8fde7fb2e308c65d018ce81e0e913de177d (HEAD -> ldap_lastname)
Author: Ying Chen <yingchen@cloudera.com>
Date:   Thu Feb 27 17:02:15 2020 -0800

    HUE-9180 [useradmin] Convert LDAP names to unicode to reduce length

:100644 100644 e7875c198e... a24ed3f172... M    apps/useradmin/src/useradmin/ldap_access.py
:100644 100644 310ff55bf2... a15535a901... M    apps/useradmin/src/useradmin/test_ldap.py


  • 0
  • 0
  • 4
  • 0
  • 4
Description From Last Updated
romain
  1. Jira Id in title and add a unit test? (e.g. https://github.com/cloudera/hue/blob/master/desktop/core/src/desktop/lib/rest/resource_test.py#L34)

  2. 
      
yingc
romain
  1. 
      
  2. goood_first_name --> good_first_name?

  3. assert_true --> assert_equal(user_info[0]['first'], goood_first_name)

  4. apps/useradmin/src/useradmin/test_ldap.py (Diff revision 2)
     
     
     
     
     
     
     

    from nose.tools import assert_equal, assert_true, .... assert_raises

    assert_raises(ValidationError, user.save)

    where ValidationError is the class of the exception raised

  5. assert_equal(user.first_name, goood_first_name)

  6. 
      
yingc
romain
  1. Ship It!
  2. 
      
yingc
yingc
Review request changed

Status: Closed (submitted)

Loading...