HUE-9204 [useradmin] Filter not yet login users out of active users metric

Review Request #14899 — Created March 20, 2020 and submitted March 24, 2020, 7:19 p.m.

Information
Owner:	yingc
Repository:	hue
Branch:	ying-test3
Bugs:	HUE-9204
Depends On:
Reviewers
Groups:
People:	johan, ranade, romain, weixia

Description

commit eafb3358558893fa20a9b0555c3efab3f7ae4599 (HEAD -> active_users)
Author: Ying Chen <yingchen@cloudera.com>
Date:   Fri Mar 20 15:03:43 2020 -0700

    HUE-9204 [useradmin] Filter not yet login users out of active users metric

:100644 100644 8244f2d86a... cda2aefc44... M    apps/useradmin/src/useradmin/metrics.py
:100644 100644 44d2248e73... 63acefd4de... M    apps/useradmin/src/useradmin/tests.py

Testing Done

Issues

0
0
2
0
All Issues: 2

Description	From	Last Updated
Why true and not false?	romain	March 20, 2020, 5:06 p.m.
Really needed? null is default in the model	romain	March 20, 2020, 7:44 p.m.

Branch:

-	ying-test3
+	master

Diff:

Revision 2 (+15 -1)

Show changes

	apps/useradmin/src/useradmin/metrics.py
	apps/useradmin/src/useradmin/tests.py

apps/useradmin/src/useradmin/metrics.py (Diff revision 1)
Show all issues
```
Why true and not false?
```

Branch:

-	master
+	ying-test3

Diff:

Revision 3 (+15 -1)

Show changes

	apps/useradmin/src/useradmin/metrics.py
	apps/useradmin/src/useradmin/tests.py

Ship it!

apps/useradmin/src/useradmin/tests.py (Diff revision 3)
Show all issues
```
Really needed?
null is default in the model
```

Diff:

Revision 4 (+14 -1)

Show changes

	apps/useradmin/src/useradmin/metrics.py
	apps/useradmin/src/useradmin/tests.py

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 3.0.17

HUE-9204 [useradmin] Filter not yet login users out of active users metric

Branch:

Diff:

Branch:

Diff:

Diff:

Status: Closed (submitted)