HUE-9187 [editor] Log connector dialect name instead of connector id

Review Request #14907 — Created March 23, 2020 and submitted

romain
hue
master
HUE-9187
hue
johan, ranade, romain, weixia, yingc
commit 41cbadf6f4e190757b28590af40c78f525abdb58
Author: Romain <romain.rigaux@gmail.com>
Date:   Mon Mar 23 13:26:27 2020 -0700

    HUE-9187 [editor] Log connector dialect name instead of connector id
    
    As ids are more personal and dialect name more useful to know.

:100644 100644 73b979e295 4b40feae0f M	desktop/core/src/desktop/js/api/apiHelper.js
:100644 100644 1fd769bd52 1278e9b651 M	desktop/core/src/desktop/js/apps/notebook2/execution/executable.js
:100644 100644 175c702074 d0ed0941f7 M	desktop/libs/notebook/src/notebook/api.py
:100644 100644 9f225c82d8 0def42bf69 M	desktop/libs/notebook/src/notebook/urls.py

manual

Probably will need to update CI test templates

  • 1
  • 0
  • 0
  • 0
  • 1
Description From Last Updated
Why do we need this btw... Shouldn't connector id be enough? i.e. drop the part after api/execute for v2. If ... johan johan
johan
  1. Ship It!
  2. 
      
johan
  1. 
      
  2. Why do we need this btw... Shouldn't connector id be enough? i.e. drop the part after api/execute for v2.

    If it's about logging why not just add an info log in execute?

    1. It is friendlier to see something /../hive (like before) than ../999 in the calls

  3. 
      
romain
Review request changed

Status: Closed (submitted)

Loading...