HUE-9187 [editor] Drop the mako json usage of "languages" in editor v2

Review Request #14910 — Created March 24, 2020 and submitted

johan
hue
master
hue
jgauthier, ranade, romain, roohi, weixia, yingc
commit 1ce088c425f2f66d37e5fb5fcec2303a914a9b4e
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Tue Mar 24 14:30:53 2020 +0100

    HUE-9187 [editor] Drop the mako json usage of "languages" in editor v2
    
    This takes care of mismatch issues from the get_config API

:100644 100644 7a0a63295c 2570ce6b6d M	apps/beeswax/src/beeswax/templates/execute.mako
:100644 100644 bd81a32e2c 19c453f45a M	desktop/core/src/desktop/js/apps/notebook2/editorViewModel.js
:100644 100644 4433c9f89b 2d8e5faf53 M	desktop/core/src/desktop/js/ko/components/assist/ko.assistDbPanel.js
:100644 100644 e29e88a97d 88a19bba27 M	desktop/core/src/desktop/js/ko/components/assist/ko.assistPanel.js
:100644 100644 8856f17a72 603df5063e M	desktop/libs/notebook/src/notebook/templates/editor_components.mako
:100644 100644 ff461524d2 a137a00833 M	desktop/libs/notebook/src/notebook/templates/editor_components2.mako

commit ac63470109f6aa84b33bc18ce19b0b0ffb4bd563
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Tue Mar 24 14:16:50 2020 +0100

    HUE-9187 [editor] Remove mako dependency on interface in editor v2

:100644 100644 edf0bee3a4 bd81a32e2c M	desktop/core/src/desktop/js/apps/notebook2/editorViewModel.js
:100644 100644 f8933fa4f4 2917883c94 M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:100644 100644 93f08ef0f2 10a1386b00 M	desktop/core/src/desktop/models.py
Manual on Chrome
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
romain
  1. 
      
  2. desktop/core/src/desktop/models.py (Diff revision 1)
     
     

    And later I can move it to the dialect types

    1. Indeed better. I'll move some more attributes there, that way we can drop the mako dependency for the editor.

  3. 
      
johan
Review request changed

Status: Closed (submitted)

Loading...