HUE-9234 [core] Add coordinator_url in hue.ini config in impala section

Review Request #14945 — Created April 2, 2020 and updated April 2, 2020, 3:25 p.m.

Information
Owner:	ranade
Repository:	hue
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	hue
People:	johan, ranade, romain, subrata, weixia, yingc

Description

commit 5d6b74a2e44bf0a01a3851856dbd02fff3fbe68e
Author: Prakash Ranade <ranade@cloudera.com>
Date:   Thu Apr 2 14:41:45 2020 -0700

    HUE-9234 [core] Add coordinator_url in hue.ini config in impala section

:100644 100644 a188d6bb0e 1565f3fc0d M	apps/impala/src/impala/conf.py
:100644 100644 ba35ce8e79 35be011dbe M	apps/impala/src/impala/server.py
:100644 100644 10c818ae4f 0e40262ba1 M	desktop/conf.dist/hue.ini
:100644 100644 be37e38c41 f3ea07794c M	desktop/conf/pseudo-distributed.ini.tmpl

Testing Done

Tested on local DWX environment.

Issues

1
0
1
0
All Issues: 2

Description	From	Last Updated
Shouldn't it be http_addr = COORDINATOR_URL.get() ?	romain	April 2, 2020, 3:12 p.m.
Just FYI for later: Realizing, later if there is an issue when we need HTTPS, it might be simpler to ...	romain	April 2, 2020, 3:25 p.m.

Ship it!

Could you also update both ini templates below so that they have this new property in the [impala] section?

https://github.com/cloudera/hue/blob/master/desktop/conf.dist/hue.ini
https://github.com/cloudera/hue/blob/master/desktop/conf/pseudo-distributed.ini.tmpl

ranade April 2, 2020, 3:12 p.m.
```
fixed
```

apps/impala/src/impala/server.py (Diff revision 1)
Show all issues
```
Shouldn't it be
http_addr = COORDINATOR_URL.get()
?
```

Description:

~		commit 543514325c63e9af07f21e868915a64283745583
	~	commit 5d6b74a2e44bf0a01a3851856dbd02fff3fbe68e
		Author: Prakash Ranade ranade@cloudera.com
		Date: Thu Apr 2 14:41:45 2020 -0700

		HUE-9234 [core] Add coordinator_url in hue.ini config in impala section

		:100644 100644 a188d6bb0e 1565f3fc0d M apps/impala/src/impala/conf.py
~		:100644 100644 ba35ce8e79 3f3388a2ba M apps/impala/src/impala/server.py
	~	:100644 100644 ba35ce8e79 35be011dbe M apps/impala/src/impala/server.py
	+	:100644 100644 10c818ae4f 0e40262ba1 M desktop/conf.dist/hue.ini
	+	:100644 100644 be37e38c41 f3ea07794c M desktop/conf/pseudo-distributed.ini.tmpl

Diff:

Revision 2 (+18 -2)

Show changes

	apps/impala/src/impala/conf.py
	apps/impala/src/impala/server.py
	desktop/conf/pseudo-distributed.ini.tmpl
	desktop/conf.dist/hue.ini

Ship it!

```
Ship It!
```

Fix it!

apps/impala/src/impala/server.py (Diff revision 2)

Show all issues

Just FYI for later:
Realizing, later if there is an issue when we need HTTPS, it might be simpler to provide the full URL, e.g. https://coordinator:20000 and just return here
But we can see when it comes

You have a pending review.

Review Board 3.0.18

HUE-9234 [core] Add coordinator_url in hue.ini config in impala section

Description:

Diff: