HUE-9253 [filebrowser] Fix - ECS S3 timestamp with milliseconds

Review Request #15012 — Created April 14, 2020 and updated

quadoss
hue
master
HUE-9253
hue
johan, ranade, romain, weixia, yingc
commit ddcd7ac24940eafa6678d009702b5d42d2743358
Author: Mahesh Balakrishnan <mbalakrishnan@cloudera.com>
Date:   Tue Apr 14 15:14:39 2020 -0700

    HUE-9253 [filebrowser] Fix - ECS S3 timestamp with milliseconds

:100644 100644 1829724894 76699cdfd0 M	desktop/libs/aws/src/aws/s3/__init__.py


  • 2
  • 0
  • 1
  • 0
  • 3
Description From Last Updated
How about adding a unit test? https://github.com/cloudera/hue/blob/master/desktop/libs/aws/src/aws/s3/s3_test.py https://docs.gethue.com/developer/development/#running-the-api-tests romain romain
Can remote the outer parentheisis ( ..... ) as no-ops? nit: might be the same simpler: datetime[-4:-1] >= '000' romain romain
romain
  1. Nice!

  2. desktop/libs/aws/src/aws/s3/__init__.py (Diff revision 1)
     
     

    How about adding a unit test?

    https://github.com/cloudera/hue/blob/master/desktop/libs/aws/src/aws/s3/s3_test.py

    https://docs.gethue.com/developer/development/#running-the-api-tests

  3. 
      
quadoss
romain
  1. Nice!

    And always easier to understand a commit by looking at the test update :)

  2. desktop/libs/aws/src/aws/s3/__init__.py (Diff revision 2)
     
     

    Can remote the outer parentheisis ( ..... ) as no-ops?

    nit: might be the same simpler:

    datetime[-4:-1] >= '000'

    1. Good to fix and push?

  3. 
      
quadoss
romain
  1. Nice!

  2. desktop/libs/aws/src/aws/s3/__init__.py (Diff revision 3)
     
     

    nit: (...) parenthesis not needed

  3. 
      
quadoss
Review request changed

Change Summary:

Did not realize the parentheisis.. removed it now.

Diff:

Revision 4 (+4 -1)

Show changes

romain
  1. Nice!

    And fill free to push or send the PR when the review has 'Fix it and ship it!'!

  2. 
      
Loading...